WordPress.org

Make WordPress Core

Changeset 42864 for trunk


Ignore:
Timestamp:
03/20/2018 10:43:58 PM (4 months ago)
Author:
SergeyBiryukov
Message:

Media: On Media Settings screen, make the pairs of labels and inputs always stacked vertically, on both mobile and desktop screens.

Make <br /> tags on the screen behave as line breaks again after [41836]. Add a missing fieldset + legend for better accessibility.

Props afercia, RavanH, obenland, garrett-eclipse.
Fixes #42724. See #34539.

Location:
trunk/src/wp-admin
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/css/common.css

    r42794 r42864  
    39533953}
    39543954
    3955 .options-media-php br {
    3956     display: none;
    3957 }
    3958 
    3959 @media screen and (max-width: 375px) {
    3960     .options-media-php input[type="number"][name*="_size_"] {
    3961         margin: 5px 0;
    3962     }
    3963     .options-media-php label[for*="_size_h"]:before {
    3964         content: "";
    3965         display: block;
    3966     }
    3967     .options-media-php br {
    3968         display: block;
    3969     }
    3970 }
    3971 
    39723955@media screen and (max-width: 320px) {
    39733956    /* Prevent default center alignment and larger font for the Right Now widget when
  • trunk/src/wp-admin/css/forms.css

    r42641 r42864  
    439439}
    440440
    441 .options-media-php label[for*="_size_"],
     441.options-media-php [for*="_size_"] {
     442    min-width: 10em;
     443    vertical-align: baseline;
     444}
     445
     446.options-media-php .small-text[name*="_size_"] {
     447    margin: 0 0 1em;
     448}
     449
    442450#misc-publishing-actions label {
    443451    vertical-align: baseline;
  • trunk/src/wp-admin/options-media.php

    r42343 r42864  
    5555<tr>
    5656<th scope="row"><?php _e( 'Thumbnail size' ); ?></th>
    57 <td>
     57<td><fieldset><legend class="screen-reader-text"><span><?php _e( 'Thumbnail size' ); ?></span></legend>
    5858<label for="thumbnail_size_w"><?php _e( 'Width' ); ?></label>
    5959<input name="thumbnail_size_w" type="number" step="1" min="0" id="thumbnail_size_w" value="<?php form_option( 'thumbnail_size_w' ); ?>" class="small-text" />
     60<br />
    6061<label for="thumbnail_size_h"><?php _e( 'Height' ); ?></label>
    6162<input name="thumbnail_size_h" type="number" step="1" min="0" id="thumbnail_size_h" value="<?php form_option( 'thumbnail_size_h' ); ?>" class="small-text" />
    62 <p><input name="thumbnail_crop" type="checkbox" id="thumbnail_crop" value="1" <?php checked( '1', get_option( 'thumbnail_crop' ) ); ?>/>
    63 <label for="thumbnail_crop"><?php _e( 'Crop thumbnail to exact dimensions (normally thumbnails are proportional)' ); ?></label></p>
     63</fieldset>
     64<input name="thumbnail_crop" type="checkbox" id="thumbnail_crop" value="1" <?php checked( '1', get_option( 'thumbnail_crop' ) ); ?>/>
     65<label for="thumbnail_crop"><?php _e( 'Crop thumbnail to exact dimensions (normally thumbnails are proportional)' ); ?></label>
    6466</td>
    6567</tr>
Note: See TracChangeset for help on using the changeset viewer.