Changeset 42874

Timestamp:

03/24/2018 08:25:07 PM (7 years ago)

Author:

adamsilverstein

Message:

Media: Fix image cropping on touch screen devices.

• In initCrop, handle touch events in addition to mouse events.
• In imageSelect jQuery plugin, accept event.which of 0 as provided by touch events.

Props yahil, alexgso, joemcgill.
Merges [42818] to the 4.9 branch.
Fixes #41242.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• src/wp-admin/js/image-edit.js (modified) (1 diff)
• src/wp-includes/js/imgareaselect/jquery.imgareaselect.js (modified) (1 diff)

branches/4.9/src/wp-admin/js/image-edit.js

@@ -628 +628 @@
                  * @returns {void}
                  */
-                parent.children().mousedown(function(e){
+                parent.children().on( 'mousedown, touchstart', function(e){
                     var ratio = false, sel, defRatio;
 

branches/4.9/src/wp-includes/js/imgareaselect/jquery.imgareaselect.js

@@ -749 +749 @@
     function imgMouseDown(event) {
         /* Ignore the event if animation is in progress */
-        if (event.which != 1 || $outer.is(':animated')) return false;
+        if (event.which > 1 || $outer.is(':animated')) return false;
 
         adjust();