Changeset 42966 for trunk/src/wp-admin/includes/revision.php

Timestamp:

04/10/2018 04:11:55 PM (5 years ago)

Author:

adamsilverstein

Message:

Revisions: improve show_split_view=false support for title.

• When show_split_view argument false, show title changes in a single column and only show title once if title is unchanged.

Props johnbillion, mbelchev.
Fixes #42402.  

File:

• trunk/src/wp-admin/includes/revision.php (modified) (1 diff)

trunk/src/wp-admin/includes/revision.php

@@ -112 +112 @@
             // No, you didn't see this.
             $diff  = '<table class="diff"><colgroup><col class="content diffsplit left"><col class="content diffsplit middle"><col class="content diffsplit right"></colgroup><tbody><tr>';
-            $diff .= '<td>' . esc_html( $compare_from->post_title ) . '</td><td></td><td>' . esc_html( $compare_to->post_title ) . '</td>';
-            $diff .= '</tr></tbody>';
+
+            // In split screen mode, show the title before/after side by side.
+            if ( true === $args['show_split_view'] ) {
+                $diff .= '<td>' . esc_html( $compare_from->post_title ) . '</td><td></td><td>' . esc_html( $compare_to->post_title ) . '</td>';
+            } else {
+                $diff .= '<td>' . esc_html( $compare_from->post_title ) . '</td>';
+
+                // In single column mode, only show the title once if unchanged.
+                if ( $compare_from->post_title !== $compare_to->post_title ) {
+                    $diff .= '</tr><tr><td>' . esc_html( $compare_to->post_title ) . '</td>';
+                }
+            }
+
+            $diff .= '</tr></tbody>';
             $diff .= '</table>';
         }