Changeset 43045

Timestamp:

04/30/2018 06:52:59 PM (7 years ago)

Author:

iandunn

Message:

Privacy: Use a CSPRNG in export filenames for more security.

rand() is deterministic and therefore offers much less protection in this context. wp_generate_password() is a convenient wrapper around wp_rand(), which uses random_int() to generate cryptographically-secure psuedorandom numbers.

See #43546.

File:

• trunk/src/wp-admin/includes/file.php (modified) (1 diff)

trunk/src/wp-admin/includes/file.php

@@ -2043 +2043 @@
     $stripped_email       = str_replace( '@', '-at-', $email_address );
     $stripped_email       = sanitize_title( $stripped_email ); // slugify the email address
-    $obscura              = md5( rand() );
+    $obscura              = wp_generate_password( 32, false, false );
     $file_basename        = 'wp-personal-data-file-' . $stripped_email . '-' . $obscura;
     $html_report_filename = $file_basename . '.html';