Changeset 43061 for trunk/src/wp-admin/includes/ajax-actions.php

Timestamp:

05/01/2018 07:26:53 PM (8 years ago)

Author:

azaozz

Message:

Privacy: improve wp_privacy_erase_personal_data(), return boolean values.

Props ericdaams.
See #43602.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (4 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -4565 +4565 @@
      *
      *         @type string $callback               Callable eraser that accepts an email address and
-     *                                              a page and returns an array with the number of items
-     *                                              removed, the number of items retained and any messages
+     *                                              a page and returns an array with boolean values for
+     *                                              whether items were removed or retained and any messages
      *                                              from the eraser, as well as if additional pages are
      *                                              available.
@@ -4633 +4633 @@
         }
 
-        if ( ! array_key_exists( 'num_items_removed', $response ) ) {
+        if ( ! array_key_exists( 'items_removed', $response ) ) {
             wp_send_json_error(
                 sprintf(
                     /* translators: %1$s: eraser friendly name, %2$d: array index */
-                    __( 'Expected num_items_removed key in response array from %1$s eraser (index %2$d).' ),
+                    __( 'Expected items_removed key in response array from %1$s eraser (index %2$d).' ),
                     esc_html( $eraser_friendly_name ),
                     $eraser_index
@@ -4644 +4644 @@
         }
 
-        if ( ! array_key_exists( 'num_items_retained', $response ) ) {
+        if ( ! array_key_exists( 'items_retained', $response ) ) {
             wp_send_json_error(
                 sprintf(
                     /* translators: %1$s: eraser friendly name, %2$d: array index */
-                    __( 'Expected num_items_retained key in response array from %1$s eraser (index %2$d).' ),
+                    __( 'Expected items_retained key in response array from %1$s eraser (index %2$d).' ),
                     esc_html( $eraser_friendly_name ),
                     $eraser_index
@@ -4690 +4690 @@
         // No erasers, so we're done.
         $response = array(
-            'num_items_removed'  => 0,
-            'num_items_retained' => 0,
-            'messages'           => array(),
-            'done'               => true,
+            'items_removed'  => false,
+            'items_retained' => false,
+            'messages'       => array(),
+            'done'           => true,
         );
     }