Changeset 43087 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-taxonomies-controller.php

Timestamp:

05/02/2018 01:24:30 AM (8 years ago)

Author:

pento

Message:

REST API: Filter responses based on the _fields parameter, before data is processed.

Historically, the REST API would generate the entire response object, including running expensive filters, then it would apply the _fields parameter, discarding the fields that weren't specificed.

This change causes _fields to be applied earlier, so that only requested fields are processed.

Props danielbachhuber.
See #43874.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-taxonomies-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-taxonomies-controller.php

@@ -182 +182 @@
         public function prepare_item_for_response( $taxonomy, $request ) {
                 $base = ! empty( $taxonomy->rest_base ) ? $taxonomy->rest_base : $taxonomy->name;
-                $data = array(
-                        'name'         => $taxonomy->label,
-                        'slug'         => $taxonomy->name,
-                        'capabilities' => $taxonomy->cap,
-                        'description'  => $taxonomy->description,
-                        'labels'       => $taxonomy->labels,
-                        'types'        => $taxonomy->object_type,
-                        'show_cloud'   => $taxonomy->show_tagcloud,
-                        'hierarchical' => $taxonomy->hierarchical,
-                        'rest_base'    => $base,
-                        'visibility'   => array(
+
+                $fields = $this->get_fields_for_response( $request );
+                $data   = array();
+
+                if ( in_array( 'name', $fields, true ) ) {
+                        $data['name'] = $taxonomy->label;
+                }
+
+                if ( in_array( 'slug', $fields, true ) ) {
+                        $data['slug'] = $taxonomy->name;
+                }
+
+                if ( in_array( 'capabilities', $fields, true ) ) {
+                        $data['capabilities'] = $taxonomy->cap;
+                }
+
+                if ( in_array( 'description', $fields, true ) ) {
+                        $data['description'] = $taxonomy->description;
+                }
+
+                if ( in_array( 'labels', $fields, true ) ) {
+                        $data['labels'] = $taxonomy->labels;
+                }
+
+                if ( in_array( 'types', $fields, true ) ) {
+                        $data['types'] = $taxonomy->object_type;
+                }
+
+                if ( in_array( 'show_cloud', $fields, true ) ) {
+                        $data['show_cloud'] = $taxonomy->show_tagcloud;
+                }
+
+                if ( in_array( 'hierarchical', $fields, true ) ) {
+                        $data['hierarchical'] = $taxonomy->hierarchical;
+                }
+
+                if ( in_array( 'rest_base', $fields, true ) ) {
+                        $data['rest_base'] = $base;
+                }
+
+                if ( in_array( 'visibility', $fields, true ) ) {
+                        $data['visibility'] = array(
                                 'public'             => (bool) $taxonomy->public,
                                 'publicly_queryable' => (bool) $taxonomy->publicly_queryable,
@@ -199 +230 @@
                                 'show_in_quick_edit' => (bool) $taxonomy->show_in_quick_edit,
                                 'show_ui'            => (bool) $taxonomy->show_ui,
-                        ),
-                );
+                        );
+                }
 
                 $context = ! empty( $request['context'] ) ? $request['context'] : 'view';