Changeset 43094

Timestamp:

05/02/2018 02:18:48 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Privacy: Use a CSPRNG in export filenames for more security.

rand() is deterministic and therefore offers much less protection in this context. wp_generate_password() is a convenient wrapper around wp_rand(), which uses random_int() to generate cryptographically-secure psuedorandom numbers.

Props iandunn.
Merges [43045] to the 4.9 branch.
See #43546.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/file.php (modified) (1 diff)

branches/4.9/src/wp-admin/includes/file.php

@@ -1906 +1906 @@
     $stripped_email       = str_replace( '@', '-at-', $email_address );
     $stripped_email       = sanitize_title( $stripped_email ); // slugify the email address
-    $obscura              = md5( rand() );
+    $obscura              = wp_generate_password( 32, false, false );
     $file_basename        = 'wp-personal-data-file-' . $stripped_email . '-' . $obscura;
     $html_report_filename = $file_basename . '.html';