Changeset 43147

Timestamp:

05/03/2018 05:24:35 PM (6 years ago)

Author:

iandunn

Message:

Privacy: Limit Privacy Settings screen to Super Admins in Multisite.

In many common Multisite use cases, the network administrator will want to set a network-wide privacy policy -- via the privacy_policy_url filter -- for consistency and convenience. When that's done, the Privacy Settings screen on individual sites becomes unnecessary, and may confuse administrators of those sites when they see that their changes don't have any effect on the policy link in the footer.

Since we can't programatically determine which behavior the network admins would like, the safest default setting is to restrict the ability to super admins, and let them delegate it to individual site owners via a plugin, if they'd like to.

Fixes #43935.

Location:

trunk

Files:

• src/wp-admin/menu.php (modified) (1 diff)
• src/wp-admin/privacy.php (modified) (1 diff)
• src/wp-includes/capabilities.php (modified) (1 diff)
• tests/phpunit/tests/user/capabilities.php (modified) (2 diffs)

trunk/src/wp-admin/menu.php

@@ -271 +271 @@
     $submenu['options-general.php'][30] = array( __( 'Media' ), 'manage_options', 'options-media.php' );
     $submenu['options-general.php'][40] = array( __( 'Permalinks' ), 'manage_options', 'options-permalink.php' );
-    $submenu['options-general.php'][45] = array( __( 'Privacy' ), 'manage_options', 'privacy.php' );
+    $submenu['options-general.php'][45] = array( __( 'Privacy' ), 'manage_privacy_policy', 'privacy.php' );
 
 $_wp_last_utility_menu = 80; // The index of the last top-level menu in the utility menu group

trunk/src/wp-admin/privacy.php

@@ -10 +10 @@
 require_once( dirname( __FILE__ ) . '/admin.php' );
 
-if ( ! current_user_can( 'manage_options' ) ) {
+if ( ! current_user_can( 'manage_privacy_policy' ) ) {
     wp_die( __( 'Sorry, you are not allowed to manage privacy on this site.' ) );
 }

trunk/src/wp-includes/capabilities.php

@@ -558 +558 @@
         case 'export_others_personal_data':
         case 'erase_others_personal_data':
+        case 'manage_privacy_policy':
             $caps[] = is_multisite() ? 'manage_network' : 'manage_options';
             break;

trunk/tests/phpunit/tests/user/capabilities.php

@@ -240 +240 @@
             'export_others_personal_data' => array( 'administrator' ),
             'erase_others_personal_data'  => array( 'administrator' ),
+            'manage_privacy_policy'       => array( 'administrator' ),
 
             'edit_categories'        => array( 'administrator', 'editor' ),
@@ -274 +275 @@
             'export_others_personal_data' => array( '' ),
             'erase_others_personal_data'  => array( '' ),
+            'manage_privacy_policy'       => array(),
 
             'customize'              => array( 'administrator' ),