Changeset 43183 for trunk

Timestamp:

05/08/2018 11:28:47 PM (7 years ago)

Author:

iandunn

Message:

Privacy: Mark processed requests as completed instead of confirmed.

r43008 refactored the request flow to make several improvements, but accidentally marked completed requests as confirmed. This commit restores the intended statuses, so that the data and corresponding UI reflect reality.

Props allendav, birgire.
Fixes #43913.

Location:

trunk

Files:

• src/wp-admin/includes/user.php (modified) (2 diffs)
• tests/phpunit/tests/privacy (added)
• tests/phpunit/tests/privacy/wpPrivacyCompletedRequest.php (added)

trunk/src/wp-admin/includes/user.php

@@ -610 +610 @@
 
 /**
- * Marks a request as completed by the admin and logs the datetime.
+ * Marks a request as completed by the admin and logs the current timestamp.
  *
  * @since 4.9.6
  * @access private
  *
- * @param int $request_id Request ID.
- * @return int|WP_Error Request ID on succes or WP_Error.
+ * @param  int          $request_id Request ID.
+ * @return int|WP_Error $request    Request ID on success or WP_Error.
  */
 function _wp_privacy_completed_request( $request_id ) {
@@ -626 +626 @@
     }
 
-    update_post_meta( $request_id, '_wp_user_request_confirmed_timestamp', time() );
+    update_post_meta( $request_id, '_wp_user_request_completed_timestamp', time() );
 
     $request = wp_update_post( array(
         'ID'          => $request_id,
-        'post_status' => 'request-confirmed',
+        'post_status' => 'request-completed',
     ) );