Changeset 43214

Timestamp:

05/10/2018 03:53:24 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Privacy: Reposition admin pointer to avoid covering collapsed menu.

Previously the pointer overlapped the menu in order to draw attention to the fact that it applies to both the Tools and Settings menus. That caused a conflict if the menu was collapsed, though, because the icons were covered by the pointer and therefore inaccessible.

Additionally, minor tweaks were made to the text order and formatting. The order of the two sections was swapped in the title and paragraph, in order to match the order of the corresponding menu items. The spacing around headings and paragraphs was tweaked to remove extraneous whitespace.

Props littler.chicken, desrosj, ianbelanger, melchoyce.
Merges [43210] to the 4.9 branch.
Fixes #43961.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-wp-internal-pointers.php (modified) (3 diffs)
• src/wp-includes/css/wp-pointer.css (modified) (1 diff)

branches/4.9/src/wp-admin/includes/class-wp-internal-pointers.php

@@ -162 +162 @@
      */
     public static function pointer_wp496_privacy() {
-        $content  = '<h3>' . __( 'Privacy and Personal Data' ) . '</h3>';
+        $content  = '<h3>' . __( 'Personal Data and Privacy' ) . '</h3>';
+        $content .= '<h4>' . __( 'Personal Data Export and Erasure' ) . '</h4>';
+        $content .= '<p>' . __( 'New <strong>Tools</strong> have been added to help you with personal data export and erasure requests.' ) . '</p>';
         $content .= '<h4>' . __( 'Privacy Policy' ) . '</h4>';
         $content .= '<p>' . __( 'Create or select your site&#8217;s privacy policy page under <strong>Settings &gt; Privacy</strong> to keep your users informed and aware.' ) . '</p>';
-        $content .= '<h4>' . __( 'Personal Data Export and Erasure' ) . '</h4>';
-        $content .= '<p>' . __( 'New <strong>Tools</strong> have been added to help you with personal data export and erasure requests.' ) . '</p>';
 
         if ( is_rtl() ) {
@@ -172 +172 @@
                 'edge'  => 'right',
                 'align' => 'left',
-                'at'    => 'left+40',
             );
         } else {
@@ -178 +177 @@
                 'edge'  => 'left',
                 'align' => 'right',
-                'at'    => 'right-40 bottom'
             );
         }

branches/4.9/src/wp-includes/css/wp-pointer.css

@@ -38 +38 @@
 
 .wp-pointer-content h4 {
-    margin: 1.33em 15px;
+    margin: 1.33em 20px 1em;
+    font-size: 1.15em;
 }
 
 .wp-pointer-content p {
-    padding: 0 15px;
+    padding: 0 20px;
 }