WordPress.org

Make WordPress Core

Changeset 43227


Ignore:
Timestamp:
05/10/2018 08:17:00 PM (3 years ago)
Author:
SergeyBiryukov
Message:

General: Skip test_is_countable_ResourceBundle() on PHP 5.3 and below.

ResourceBundle is only countable in PHP 5.4+, which can be considered an acceptable edge case for WordPress core purposes.

Props jrf, ayeshrajans.
Merges [43226] to the 4.9 branch.
Fixes #43583.

Location:
branches/4.9
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/4.9

  • branches/4.9/tests/phpunit/tests/compat.php

    r43221 r43227  
    247247        }
    248248
     249        if ( version_compare( PHP_VERSION, '5.4', '<' ) ) {
     250            $this->markTestSkipped( 'ResourceBundle is only countable in PHP 5.4+' );
     251            return;
     252        }
     253
    249254        $this->assertTrue( is_countable( new ResourceBundle( 'en', null ) ) );
    250255    }
Note: See TracChangeset for help on using the changeset viewer.