Changeset 43239

Timestamp:

05/10/2018 09:40:28 PM (8 years ago)

Author:

SergeyBiryukov

Message:

Privacy: On Privacy Settings screen, check if any pages exist before displaying the page selector.

Props abdullahramzan, desrosj, melchoyce.
Merges [43238] to the 4.9 branch.
Fixes #43940.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• src/wp-admin/privacy.php (modified) (1 diff)

branches/4.9/src/wp-admin/privacy.php

@@ -168 +168 @@
                         </th>
                         <td>
-                                <form method="post" action="">
-                                        <label for="page_for_privacy_policy">
-                                                <?php _e( 'Either select an existing page:' ); ?>
-                                        </label>
-                                        <input type="hidden" name="action" value="set-privacy-page" />
-                                        <?php
-                                        wp_dropdown_pages(
-                                                array(
-                                                        'name'              => 'page_for_privacy_policy',
-                                                        'show_option_none'  => __( '&mdash; Select &mdash;' ),
-                                                        'option_none_value' => '0',
-                                                        'selected'          => $privacy_policy_page_id,
-                                                        'post_status'       => array( 'draft', 'publish' ),
-                                                )
-                                        );
-
-                                        wp_nonce_field( 'set-privacy-page' );
-
-                                        submit_button( __( 'Use This Page' ), 'primary', 'submit', false, array( 'id' => 'set-page' ) );
-                                        ?>
-                                </form>
+                                <?php
+                                $has_pages = (bool) get_posts( array(
+                                        'post_type' => 'page',
+                                        'posts_per_page' => 1,
+                                        'post_status' => array(
+                                                'publish',
+                                                'draft',
+                                        ),
+                                ) );
+
+                                if ( $has_pages ) : ?>
+                                        <form method="post" action="">
+                                                <label for="page_for_privacy_policy">
+                                                        <?php _e( 'Select an existing page:' ); ?>
+                                                </label>
+                                                <input type="hidden" name="action" value="set-privacy-page" />
+                                                <?php
+                                                wp_dropdown_pages(
+                                                        array(
+                                                                'name'              => 'page_for_privacy_policy',
+                                                                'show_option_none'  => __( '&mdash; Select &mdash;' ),
+                                                                'option_none_value' => '0',
+                                                                'selected'          => $privacy_policy_page_id,
+                                                                'post_status'       => array( 'draft', 'publish' ),
+                                                        )
+                                                );
+
+                                                wp_nonce_field( 'set-privacy-page' );
+
+                                                submit_button( __( 'Use This Page' ), 'primary', 'submit', false, array( 'id' => 'set-page' ) );
+                                                ?>
+                                        </form>
+                                <?php endif; ?>
 
                                 <form method="post" action="">
                                         <input type="hidden" name="action" value="create-privacy-page" />
                                         <span>
-                                                <?php _e( 'Or create a new page:' ); ?>
+                                                <?php
+                                                if ( $has_pages ) {
+                                                        _e( 'Or:' );
+                                                } else {
+                                                        _e( 'There are no pages.' );
+                                                }
+                                                ?>
                                         </span>
                                         <?php