Changeset 43290 for trunk

Timestamp:

05/16/2018 10:38:20 PM (8 years ago)

Author:

iandunn

Message:

Comments: Escape permalink values on edit screen to prevent XSS.

There doesn't appear to be any way for an attacker to introduce malicious input into the URL, unless a plugin is filtering the URL to add it, but it's better to be safe than sorry.

Props 1naveengiri, joyously.
Fixes #44115.

File:

• trunk/src/wp-admin/edit-form-comment.php (modified) (1 diff)

trunk/src/wp-admin/edit-form-comment.php

@@ -31 +31 @@
         <div id="comment-link-box">
                 <strong><?php _ex( 'Permalink:', 'comment' ); ?></strong>
-                <span id="sample-permalink"><a href="<?php echo $comment_link; ?>"><?php echo $comment_link; ?></a></span>
+                <span id="sample-permalink">
+                        <a href="<?php echo esc_url( $comment_link ); ?>">
+                                <?php echo esc_html( $comment_link ); ?>
+                        </a>
+                </span>
         </div>
 </div>