Changeset 43313

Timestamp:

05/25/2018 01:22:44 AM (7 years ago)

Author:

boonebgorges

Message:

Taxonomy: Improve cache handling when querying for terms using all_with_object_id.

When a term query using fields=all_with_object_id hits the cache, the
cached stdClass objects must be converted to WP_Term objects. This
was overlooked when WP_Term_Query was refactored to support object
queries in [38667].

Props dlh.
Fixes #44221.

Location:

trunk

Files:

• src/wp-includes/class-wp-term-query.php (modified) (1 diff)
• tests/phpunit/tests/term/query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-term-query.php

@@ -678 +678 @@
         $cache        = wp_cache_get( $cache_key, 'terms' );
         if ( false !== $cache ) {
-            if ( 'all' === $_fields ) {
+            if ( 'all' === $_fields || 'all_with_object_id' === $_fields ) {
                 $cache = $this->populate_terms( $cache );
             }

trunk/tests/phpunit/tests/term/query.php

@@ -316 +316 @@
         foreach ( $query->terms as $term ) {
             $this->assertSame( $t, $term->term_id );
+        }
+    }
+
+    /**
+     * @ticket 44221
+     */
+    public function test_all_with_object_id_should_return_term_objects() {
+        register_taxonomy( 'wptests_tax_1', 'post' );
+        $posts = self::factory()->post->create_many( 2 );
+        $t     = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax_1' ) );
+
+        foreach ( $posts as $p ) {
+            wp_set_object_terms( $p, array( $t ), 'wptests_tax_1' );
+        }
+
+        $query = new WP_Term_Query();
+        $args = array(
+            'taxonomy'   => 'wptests_tax_1',
+            'object_ids' => $posts,
+            'fields'     => 'all_with_object_id',
+        );
+
+        $terms = $query->query( $args );
+        $this->assertNotEmpty( $terms );
+        foreach ( $terms as $term ) {
+            $this->assertInstanceOf( 'WP_Term', $term );
+            $this->assertObjectHasAttribute( 'object_id', $term );
+        }
+
+        // Run again to check the cached response.
+        $terms = $query->query( $args );
+        $this->assertNotEmpty( $terms );
+        foreach ( $terms as $term ) {
+            $this->assertInstanceOf( 'WP_Term', $term );
+            $this->assertObjectHasAttribute( 'object_id', $term );
         }
     }