Changeset 43389 for trunk/tests/phpunit/tests/date/dateI18n.php

Timestamp:

07/04/2018 11:42:59 PM (6 years ago)

Author:

flixos90

Message:

Date/Time: Fix usage of $gmt parameter in date_i18n() and clarify its behavior.

The docs for date_i18n() and its filter now correctly state that the $gmt parameter is only taken into account if no timestamp is provided. Furthermore, a bug with that parameter is fixed, as it is now ensured that the timezone used with it is UTC.

Props Rarst.
Fixes #38771.

File:

• trunk/tests/phpunit/tests/date/dateI18n.php (modified) (2 diffs)

trunk/tests/phpunit/tests/date/dateI18n.php

@@ -15 +15 @@
 
     public function test_date_should_be_in_gmt() {
-        $this->assertEquals( strtotime( date( 'Y-m-d H:i:s' ) ), strtotime( date_i18n( 'Y-m-d H:i:s', false, true ) ), 'The dates should be equal', 2 );
+        $this->assertEquals( strtotime( date( DATE_RFC3339 ) ), strtotime( date_i18n( DATE_RFC3339, false, true ) ), 'The dates should be equal', 2 );
     }
 
@@ -31 +31 @@
         update_option( 'timezone_string', 'America/Regina' );
 
-        $this->assertEquals( strtotime( date( 'Y-m-d H:i:s' ) ), strtotime( date_i18n( 'Y-m-d H:i:s', false, true ) ), 'The dates should be equal', 2 );
+        $this->assertEquals( strtotime( date( DATE_RFC3339 ) ), strtotime( date_i18n( DATE_RFC3339, false, true ) ), 'The dates should be equal', 2 );
     }