Changeset 43436

Timestamp:

07/09/2018 01:44:53 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Plugins: Disable "Install Now" button for plugins that require a higher version of PHP or WordPress.

Display a notice with an explanation and the steps required to resolve the issue.

Props afragen, schlessera, flixos90, nerrad, melchoyce, boemedia, hedgefield, joyously, johnalarcon, lakenh, afercia, acirujano, ibantxillo, SergeyBiryukov.
Fixes #43986.

Location:

trunk/src/wp-admin

Files:

• css/list-tables.css (modified) (1 diff)
• includes/class-wp-plugin-install-list-table.php (modified) (5 diffs)
• includes/plugin-install.php (modified) (2 diffs)

trunk/src/wp-admin/css/list-tables.css

@@ -1515 +1515 @@
 }
 
+.plugin-card .notice {
+    margin: 20px 20px 0 20px;
+}
+
 .plugin-icon {
     position: absolute;

trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -497 +497 @@
             }
 
+            $wp_version = get_bloginfo( 'version' );
+
+            $compatible_php = ( empty( $plugin['requires_php'] ) || version_compare( substr( phpversion(), 0, strlen( $plugin['requires_php'] ) ), $plugin['requires_php'], '>=' ) );
+            $tested_wp      = ( empty( $plugin['tested'] ) || version_compare( substr( $wp_version, 0, strlen( $plugin['tested'] ) ), $plugin['tested'], '<=' ) );
+            $compatible_wp  = ( empty( $plugin['requires'] ) || version_compare( substr( $wp_version, 0, strlen( $plugin['requires'] ) ), $plugin['requires'], '>=' ) );
+
             $action_links = array();
 
@@ -505 +511 @@
                     case 'install':
                         if ( $status['url'] ) {
-                            $action_links[] = sprintf(
-                                '<a class="install-now button" data-slug="%s" href="%s" aria-label="%s" data-name="%s">%s</a>',
-                                esc_attr( $plugin['slug'] ),
-                                esc_url( $status['url'] ),
-                                /* translators: %s: plugin name and version */
-                                esc_attr( sprintf( __( 'Install %s now' ), $name ) ),
-                                esc_attr( $name ),
-                                __( 'Install Now' )
-                            );
+                            if ( $compatible_php && $compatible_wp ) {
+                                $action_links[] = sprintf(
+                                    '<a class="install-now button" data-slug="%s" href="%s" aria-label="%s" data-name="%s">%s</a>',
+                                    esc_attr( $plugin['slug'] ),
+                                    esc_url( $status['url'] ),
+                                    /* translators: %s: plugin name and version */
+                                    esc_attr( sprintf( __( 'Install %s now' ), $name ) ),
+                                    esc_attr( $name ),
+                                    __( 'Install Now' )
+                                );
+                            } else {
+                                $action_links[] = sprintf(
+                                    '<button type="button" class="button button-disabled" disabled="disabled">%s</button>',
+                                    _x( 'Cannot Install', 'plugin' )
+                                );
+                            }
                         }
                         break;
@@ -611 +624 @@
         ?>
         <div class="plugin-card plugin-card-<?php echo sanitize_html_class( $plugin['slug'] ); ?>">
+            <?php
+            if ( ! $compatible_php || ! $compatible_wp ) {
+                echo '<div class="notice inline notice-error notice-alt"><p>';
+                if ( ! $compatible_php && ! $compatible_wp ) {
+                    _e( 'This plugin doesn&#8217;t work with your versions of WordPress and PHP. ' );
+                    if ( current_user_can( 'update_core' ) ) {
+                        printf(
+                            /* translators: 1: "Update WordPress" screen URL, 2: "Updating PHP" page URL */
+                            __( '<a href="%1$s">Please update WordPress</a>, and then <a href="%2$s">learn more about updating PHP</a>.' ),
+                            self_admin_url( 'update-core.php' ),
+                            esc_url( __( 'https://wordpress.org/support/upgrade-php/' ) )
+                        );
+                    } else {
+                        printf(
+                            /* translators: %s: "Updating PHP" page URL */
+                            __( '<a href="%s">Learn more about updating PHP</a>.' ),
+                            esc_url( __( 'https://wordpress.org/support/upgrade-php/' ) )
+                        );
+                    }
+                } elseif ( ! $compatible_wp ) {
+                    _e( 'This plugin doesn&#8217;t work with your version of WordPress. ' );
+                    if ( current_user_can( 'update_core' ) ) {
+                        printf(
+                            /* translators: %s: "Update WordPress" screen URL */
+                            __( '<a href="%s">Please update WordPress</a>.' ),
+                            self_admin_url( 'update-core.php' )
+                        );
+                    }
+                } elseif ( ! $compatible_php  ) {
+                    _e( 'This plugin doesn&#8217;t work with your version of PHP. ' );
+                    printf(
+                        /* translators: %s: "Updating PHP" page URL */
+                        __( '<a href="%s">Learn more about updating PHP</a>.' ),
+                        esc_url( __( 'https://wordpress.org/support/upgrade-php/' ) )
+                    );
+                }
+                echo '</p></div>';
+            }
+            ?>
             <div class="plugin-card-top">
                 <div class="name column-name">
@@ -642 +694 @@
                         )
                     );
-?>
+                    ?>
                     <span class="num-ratings" aria-hidden="true">(<?php echo number_format_i18n( $plugin['num_ratings'] ); ?>)</span>
                 </div>
@@ -666 +718 @@
                 <div class="column-compatibility">
                     <?php
-                    $wp_version = get_bloginfo( 'version' );
-
-                    if ( ! empty( $plugin['tested'] ) && version_compare( substr( $wp_version, 0, strlen( $plugin['tested'] ) ), $plugin['tested'], '>' ) ) {
+                    if ( ! $tested_wp ) {
                         echo '<span class="compatibility-untested">' . __( 'Untested with your version of WordPress' ) . '</span>';
-                    } elseif ( ! empty( $plugin['requires'] ) && version_compare( substr( $wp_version, 0, strlen( $plugin['requires'] ) ), $plugin['requires'], '<' ) ) {
+                    } elseif ( ! $compatible_wp ) {
                         echo '<span class="compatibility-incompatible">' . __( '<strong>Incompatible</strong> with your version of WordPress' ) . '</span>';
                     } else {

trunk/src/wp-admin/includes/plugin-install.php

@@ -754 +754 @@
     $wp_version = get_bloginfo( 'version' );
 
-    if ( ! empty( $api->tested ) && version_compare( substr( $wp_version, 0, strlen( $api->tested ) ), $api->tested, '>' ) ) {
-        echo '<div class="notice notice-warning notice-alt"><p>' . __( '<strong>Warning:</strong> This plugin has <strong>not been tested</strong> with your current version of WordPress.' ) . '</p></div>';
-    } elseif ( ! empty( $api->requires ) && version_compare( substr( $wp_version, 0, strlen( $api->requires ) ), $api->requires, '<' ) ) {
-        echo '<div class="notice notice-warning notice-alt"><p>' . __( '<strong>Warning:</strong> This plugin has <strong>not been marked as compatible</strong> with your version of WordPress.' ) . '</p></div>';
+    $compatible_php = ( empty( $api->requires_php ) || version_compare( substr( phpversion(), 0, strlen( $api->requires_php ) ), $api->requires_php, '>=' ) );
+    $tested_wp      = ( empty( $api->tested ) || version_compare( substr( $wp_version, 0, strlen( $api->tested ) ), $api->tested, '<=' ) );
+    $compatible_wp  = ( empty( $api->requires ) || version_compare( substr( $wp_version, 0, strlen( $api->requires ) ), $api->requires, '>=' ) );
+
+    if ( ! $compatible_php ) {
+        echo '<div class="notice notice-error notice-alt"><p>';
+        printf(
+            /* translators: "Updating PHP" page URL */
+            __( '<strong>Error:</strong> This plugin <strong>requires a newer version of PHP</strong>, so unfortunately you cannot install it. <a href="%s" target="_blank">Click here to learn more about updating PHP</a>.' ),
+            esc_url( __( 'https://wordpress.org/support/upgrade-php/' ) )
+        );
+        echo '</p></div>';
+    }
+
+    if ( ! $tested_wp ) {
+        echo '<div class="notice notice-warning notice-alt"><p>';
+        _e( '<strong>Warning:</strong> This plugin <strong>has not been tested</strong> with your current version of WordPress.' );
+        echo '</p></div>';
+    } elseif ( ! $compatible_wp ) {
+        echo '<div class="notice notice-error notice-alt"><p>';
+        _e( '<strong>Error:</strong> This plugin <strong>requires a newer version of WordPress</strong>.' );
+        if ( current_user_can( 'update_core' ) ) {
+            printf(
+                /* translators: %s: "Update WordPress" screen URL */
+                ' ' . __( '<a href="%s" target="_parent">Click here to update WordPress</a>.' ),
+                self_admin_url( 'update-core.php' )
+            );
+        }
+        echo '</p></div>';
     }
 
@@ -781 +806 @@
             case 'install':
                 if ( $status['url'] ) {
-                    echo '<a data-slug="' . esc_attr( $api->slug ) . '" id="plugin_install_from_iframe" class="button button-primary right" href="' . $status['url'] . '" target="_parent">' . __( 'Install Now' ) . '</a>';
+                    if ( $compatible_php && $compatible_wp ) {
+                        echo '<a data-slug="' . esc_attr( $api->slug ) . '" id="plugin_install_from_iframe" class="button button-primary right" href="' . $status['url'] . '" target="_parent">' . __( 'Install Now' ) . '</a>';
+                    } else {
+                        printf(
+                            '<button type="button" class="button button-primary button-disabled right" disabled="disabled">%s</button>',
+                            _x( 'Cannot Install', 'plugin' )
+                        );
+                    }
                 }
                 break;