Changeset 43445 for branches/4.9/src/wp-includes/rest-api/endpoints/class-wp-rest-post-statuses-controller.php

Timestamp:

07/13/2018 06:50:51 AM (7 years ago)

Author:

pento

Message:

REST API: Filter responses based on the _fields parameter, before data is processed.

Historically, the REST API would generate the entire response object, including running expensive filters, then it would apply the _fields parameter, discarding the fields that weren't specificed.

This change causes _fields to be applied earlier, so that only requested fields are processed.

Merges [43087] to the 4.9 branch.

Props danielbachhuber.
See #43874.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api/endpoints/class-wp-rest-post-statuses-controller.php (modified) (1 diff)

branches/4.9/src/wp-includes/rest-api/endpoints/class-wp-rest-post-statuses-controller.php

@@ -196 +196 @@
     public function prepare_item_for_response( $status, $request ) {
 
-        $data = array(
-            'name'         => $status->label,
-            'private'      => (bool) $status->private,
-            'protected'    => (bool) $status->protected,
-            'public'       => (bool) $status->public,
-            'queryable'    => (bool) $status->publicly_queryable,
-            'show_in_list' => (bool) $status->show_in_admin_all_list,
-            'slug'         => $status->name,
-        );
+        $fields = $this->get_fields_for_response( $request );
+        $data   = array();
+
+        if ( in_array( 'name', $fields, true ) ) {
+            $data['name'] = $status->label;
+        }
+
+        if ( in_array( 'private', $fields, true ) ) {
+            $data['private'] = (bool) $status->private;
+        }
+
+        if ( in_array( 'protected', $fields, true ) ) {
+            $data['protected'] = (bool) $status->protected;
+        }
+
+        if ( in_array( 'public', $fields, true ) ) {
+            $data['public'] = (bool) $status->public;
+        }
+
+        if ( in_array( 'queryable', $fields, true ) ) {
+            $data['queryable'] = (bool) $status->publicly_queryable;
+        }
+
+        if ( in_array( 'show_in_list', $fields, true ) ) {
+            $data['show_in_list'] = (bool) $status->show_in_admin_all_list;
+        }
+
+        if ( in_array( 'slug', $fields, true ) ) {
+            $data['slug'] = $status->name;
+        }
 
         $context = ! empty( $request['context'] ) ? $request['context'] : 'view';