Changeset 43445 for branches/4.9/src/wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php

Timestamp:

07/13/2018 06:50:51 AM (8 years ago)

Author:

pento

Message:

REST API: Filter responses based on the _fields parameter, before data is processed.

Historically, the REST API would generate the entire response object, including running expensive filters, then it would apply the _fields parameter, discarding the fields that weren't specificed.

This change causes _fields to be applied earlier, so that only requested fields are processed.

Merges [43087] to the 4.9 branch.

Props danielbachhuber.
See #43874.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php (modified) (1 diff)

branches/4.9/src/wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php

@@ -152 +152 @@
                 $supports = get_all_post_type_supports( $post_type->name );
 
-                $data = array(
-                        'capabilities' => $post_type->cap,
-                        'description'  => $post_type->description,
-                        'hierarchical' => $post_type->hierarchical,
-                        'viewable'     => is_post_type_viewable( $post_type ),
-                        'labels'       => $post_type->labels,
-                        'name'         => $post_type->label,
-                        'slug'         => $post_type->name,
-                        'supports'     => $supports,
-                        'taxonomies'   => array_values( $taxonomies ),
-                        'rest_base'    => $base,
-                );
+                $fields = $this->get_fields_for_response( $request );
+                $data   = array();
+
+                if ( in_array( 'capabilities', $fields, true ) ) {
+                        $data['capabilities'] = $post_type->cap;
+                }
+
+                if ( in_array( 'description', $fields, true ) ) {
+                        $data['description'] = $post_type->description;
+                }
+
+                if ( in_array( 'hierarchical', $fields, true ) ) {
+                        $data['hierarchical'] = $post_type->hierarchical;
+                }
+
+                if ( in_array( 'viewable', $fields, true ) ) {
+                        $data['viewable'] = is_post_type_viewable( $post_type );
+                }
+
+                if ( in_array( 'labels', $fields, true ) ) {
+                        $data['labels'] = $post_type->labels;
+                }
+
+                if ( in_array( 'name', $fields, true ) ) {
+                        $data['name'] = $post_type->label;
+                }
+
+                if ( in_array( 'slug', $fields, true ) ) {
+                        $data['slug'] = $post_type->name;
+                }
+
+                if ( in_array( 'supports', $fields, true ) ) {
+                        $data['supports'] = $supports;
+                }
+
+                if ( in_array( 'taxonomies', $fields, true ) ) {
+                        $data['taxonomies'] = array_values( $taxonomies );
+                }
+
+                if ( in_array( 'rest_base', $fields, true ) ) {
+                        $data['rest_base'] = $base;
+                }
+
                 $context = ! empty( $request['context'] ) ? $request['context'] : 'view';
                 $data    = $this->add_additional_fields_to_object( $data, $request );