Changeset 43445 for branches/4.9/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

Timestamp:

07/13/2018 06:50:51 AM (7 years ago)

Author:

pento

Message:

REST API: Filter responses based on the _fields parameter, before data is processed.

Historically, the REST API would generate the entire response object, including running expensive filters, then it would apply the _fields parameter, discarding the fields that weren't specificed.

This change causes _fields to be applied earlier, so that only requested fields are processed.

Merges [43087] to the 4.9 branch.

Props danielbachhuber.
See #43874.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (10 diffs)

branches/4.9/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -1401 +1401 @@
         setup_postdata( $post );
 
-        $schema = $this->get_item_schema();
+        $fields = $this->get_fields_for_response( $request );
 
         // Base fields for every post.
         $data = array();
 
-        if ( ! empty( $schema['properties']['id'] ) ) {
+        if ( in_array( 'id', $fields, true ) ) {
             $data['id'] = $post->ID;
         }
 
-        if ( ! empty( $schema['properties']['date'] ) ) {
+        if ( in_array( 'date', $fields, true ) ) {
             $data['date'] = $this->prepare_date_response( $post->post_date_gmt, $post->post_date );
         }
 
-        if ( ! empty( $schema['properties']['date_gmt'] ) ) {
+        if ( in_array( 'date_gmt', $fields, true ) ) {
             // For drafts, `post_date_gmt` may not be set, indicating that the
             // date of the draft should be updated each time it is saved (see
@@ -1427 +1427 @@
         }
 
-        if ( ! empty( $schema['properties']['guid'] ) ) {
+        if ( in_array( 'guid', $fields, true ) ) {
             $data['guid'] = array(
                 /** This filter is documented in wp-includes/post-template.php */
@@ -1435 +1435 @@
         }
 
-        if ( ! empty( $schema['properties']['modified'] ) ) {
+        if ( in_array( 'modified', $fields, true ) ) {
             $data['modified'] = $this->prepare_date_response( $post->post_modified_gmt, $post->post_modified );
         }
 
-        if ( ! empty( $schema['properties']['modified_gmt'] ) ) {
+        if ( in_array( 'modified_gmt', $fields, true ) ) {
             // For drafts, `post_modified_gmt` may not be set (see
             // `post_date_gmt` comments above).  In this case, shim the value
@@ -1452 +1452 @@
         }
 
-        if ( ! empty( $schema['properties']['password'] ) ) {
+        if ( in_array( 'password', $fields, true ) ) {
             $data['password'] = $post->post_password;
         }
 
-        if ( ! empty( $schema['properties']['slug'] ) ) {
+        if ( in_array( 'slug', $fields, true ) ) {
             $data['slug'] = $post->post_name;
         }
 
-        if ( ! empty( $schema['properties']['status'] ) ) {
+        if ( in_array( 'status', $fields, true ) ) {
             $data['status'] = $post->post_status;
         }
 
-        if ( ! empty( $schema['properties']['type'] ) ) {
+        if ( in_array( 'type', $fields, true ) ) {
             $data['type'] = $post->post_type;
         }
 
-        if ( ! empty( $schema['properties']['link'] ) ) {
+        if ( in_array( 'link', $fields, true ) ) {
             $data['link'] = get_permalink( $post->ID );
         }
 
-        if ( ! empty( $schema['properties']['title'] ) ) {
+        if ( in_array( 'title', $fields, true ) ) {
             add_filter( 'protected_title_format', array( $this, 'protected_title_format' ) );
 
@@ -1492 +1492 @@
         }
 
-        if ( ! empty( $schema['properties']['content'] ) ) {
+        if ( in_array( 'content', $fields, true ) ) {
             $data['content'] = array(
                 'raw'       => $post->post_content,
@@ -1501 +1501 @@
         }
 
-        if ( ! empty( $schema['properties']['excerpt'] ) ) {
+        if ( in_array( 'excerpt', $fields, true ) ) {
             /** This filter is documented in wp-includes/post-template.php */
             $excerpt = apply_filters( 'the_excerpt', apply_filters( 'get_the_excerpt', $post->post_excerpt, $post ) );
@@ -1516 +1516 @@
         }
 
-        if ( ! empty( $schema['properties']['author'] ) ) {
+        if ( in_array( 'author', $fields, true ) ) {
             $data['author'] = (int) $post->post_author;
         }
 
-        if ( ! empty( $schema['properties']['featured_media'] ) ) {
+        if ( in_array( 'featured_media', $fields, true ) ) {
             $data['featured_media'] = (int) get_post_thumbnail_id( $post->ID );
         }
 
-        if ( ! empty( $schema['properties']['parent'] ) ) {
+        if ( in_array( 'parent', $fields, true ) ) {
             $data['parent'] = (int) $post->post_parent;
         }
 
-        if ( ! empty( $schema['properties']['menu_order'] ) ) {
+        if ( in_array( 'menu_order', $fields, true ) ) {
             $data['menu_order'] = (int) $post->menu_order;
         }
 
-        if ( ! empty( $schema['properties']['comment_status'] ) ) {
+        if ( in_array( 'comment_status', $fields, true ) ) {
             $data['comment_status'] = $post->comment_status;
         }
 
-        if ( ! empty( $schema['properties']['ping_status'] ) ) {
+        if ( in_array( 'ping_status', $fields, true ) ) {
             $data['ping_status'] = $post->ping_status;
         }
 
-        if ( ! empty( $schema['properties']['sticky'] ) ) {
+        if ( in_array( 'sticky', $fields, true ) ) {
             $data['sticky'] = is_sticky( $post->ID );
         }
 
-        if ( ! empty( $schema['properties']['template'] ) ) {
+        if ( in_array( 'template', $fields, true ) ) {
             if ( $template = get_page_template_slug( $post->ID ) ) {
                 $data['template'] = $template;
@@ -1552 +1552 @@
         }
 
-        if ( ! empty( $schema['properties']['format'] ) ) {
+        if ( in_array( 'format', $fields, true ) ) {
             $data['format'] = get_post_format( $post->ID );
 
@@ -1561 +1561 @@
         }
 
-        if ( ! empty( $schema['properties']['meta'] ) ) {
+        if ( in_array( 'meta', $fields, true ) ) {
             $data['meta'] = $this->meta->get_value( $post->ID, $request );
         }
@@ -1570 +1570 @@
             $base = ! empty( $taxonomy->rest_base ) ? $taxonomy->rest_base : $taxonomy->name;
 
-            if ( ! empty( $schema['properties'][ $base ] ) ) {
+            if ( in_array( $base, $fields, true ) ) {
                 $terms = get_the_terms( $post, $taxonomy->name );
                 $data[ $base ] = $terms ? array_values( wp_list_pluck( $terms, 'term_id' ) ) : array();