Changeset 43445 for branches/4.9/src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php

Timestamp:

07/13/2018 06:50:51 AM (7 years ago)

Author:

pento

Message:

REST API: Filter responses based on the _fields parameter, before data is processed.

Historically, the REST API would generate the entire response object, including running expensive filters, then it would apply the _fields parameter, discarding the fields that weren't specificed.

This change causes _fields to be applied earlier, so that only requested fields are processed.

Merges [43087] to the 4.9 branch.

Props danielbachhuber.
See #43874.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php (modified) (4 diffs)

branches/4.9/src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php

@@ -332 +332 @@
         setup_postdata( $post );
 
-        $schema = $this->get_item_schema();
-
-        $data = array();
-
-        if ( ! empty( $schema['properties']['author'] ) ) {
+        $fields = $this->get_fields_for_response( $request );
+        $data   = array();
+
+        if ( in_array( 'author', $fields, true ) ) {
             $data['author'] = (int) $post->post_author;
         }
 
-        if ( ! empty( $schema['properties']['date'] ) ) {
+        if ( in_array( 'date', $fields, true ) ) {
             $data['date'] = $this->prepare_date_response( $post->post_date_gmt, $post->post_date );
         }
 
-        if ( ! empty( $schema['properties']['date_gmt'] ) ) {
+        if ( in_array( 'date_gmt', $fields, true ) ) {
             $data['date_gmt'] = $this->prepare_date_response( $post->post_date_gmt );
         }
 
-        if ( ! empty( $schema['properties']['id'] ) ) {
+        if ( in_array( 'id', $fields, true ) ) {
             $data['id'] = $post->ID;
         }
 
-        if ( ! empty( $schema['properties']['modified'] ) ) {
+        if ( in_array( 'modified', $fields, true ) ) {
             $data['modified'] = $this->prepare_date_response( $post->post_modified_gmt, $post->post_modified );
         }
 
-        if ( ! empty( $schema['properties']['modified_gmt'] ) ) {
+        if ( in_array( 'modified_gmt', $fields, true ) ) {
             $data['modified_gmt'] = $this->prepare_date_response( $post->post_modified_gmt );
         }
 
-        if ( ! empty( $schema['properties']['parent'] ) ) {
+        if ( in_array( 'parent', $fields, true ) ) {
             $data['parent'] = (int) $post->post_parent;
         }
 
-        if ( ! empty( $schema['properties']['slug'] ) ) {
+        if ( in_array( 'slug', $fields, true ) ) {
             $data['slug'] = $post->post_name;
         }
 
-        if ( ! empty( $schema['properties']['guid'] ) ) {
+        if ( in_array( 'guid', $fields, true ) ) {
             $data['guid'] = array(
                 /** This filter is documented in wp-includes/post-template.php */
@@ -376 +375 @@
         }
 
-        if ( ! empty( $schema['properties']['title'] ) ) {
+        if ( in_array( 'title', $fields, true ) ) {
             $data['title'] = array(
                 'raw'      => $post->post_title,
@@ -383 +382 @@
         }
 
-        if ( ! empty( $schema['properties']['content'] ) ) {
+        if ( in_array( 'content', $fields, true ) ) {
 
             $data['content'] = array(
@@ -392 +391 @@
         }
 
-        if ( ! empty( $schema['properties']['excerpt'] ) ) {
+        if ( in_array( 'excerpt', $fields, true ) ) {
             $data['excerpt'] = array(
                 'raw'      => $post->post_excerpt,