Changeset 43445 for branches/4.9/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php

Timestamp:

07/13/2018 06:50:51 AM (8 years ago)

Author:

pento

Message:

REST API: Filter responses based on the _fields parameter, before data is processed.

Historically, the REST API would generate the entire response object, including running expensive filters, then it would apply the _fields parameter, discarding the fields that weren't specificed.

This change causes _fields to be applied earlier, so that only requested fields are processed.

Merges [43087] to the 4.9 branch.

Props danielbachhuber.
See #43874.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php (modified) (1 diff)

branches/4.9/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php

@@ -686 +686 @@
     public function prepare_item_for_response( $item, $request ) {
 
-        $schema = $this->get_item_schema();
+        $fields = $this->get_fields_for_response( $request );
         $data   = array();
 
-        if ( ! empty( $schema['properties']['id'] ) ) {
+        if ( in_array( 'id', $fields, true ) ) {
             $data['id'] = (int) $item->term_id;
         }
 
-        if ( ! empty( $schema['properties']['count'] ) ) {
+        if ( in_array( 'count', $fields, true ) ) {
             $data['count'] = (int) $item->count;
         }
 
-        if ( ! empty( $schema['properties']['description'] ) ) {
+        if ( in_array( 'description', $fields, true ) ) {
             $data['description'] = $item->description;
         }
 
-        if ( ! empty( $schema['properties']['link'] ) ) {
+        if ( in_array( 'link', $fields, true ) ) {
             $data['link'] = get_term_link( $item );
         }
 
-        if ( ! empty( $schema['properties']['name'] ) ) {
+        if ( in_array( 'name', $fields, true ) ) {
             $data['name'] = $item->name;
         }
 
-        if ( ! empty( $schema['properties']['slug'] ) ) {
+        if ( in_array( 'slug', $fields, true ) ) {
             $data['slug'] = $item->slug;
         }
 
-        if ( ! empty( $schema['properties']['taxonomy'] ) ) {
+        if ( in_array( 'taxonomy', $fields, true ) ) {
             $data['taxonomy'] = $item->taxonomy;
         }
 
-        if ( ! empty( $schema['properties']['parent'] ) ) {
+        if ( in_array( 'parent', $fields, true ) ) {
             $data['parent'] = (int) $item->parent;
         }
 
-        if ( ! empty( $schema['properties']['meta'] ) ) {
+        if ( in_array( 'meta', $fields, true ) ) {
             $data['meta'] = $this->meta->get_value( $item->term_id, $request );
         }