Changeset 43445 for branches/4.9/tests/phpunit/tests/rest-api/rest-comments-controller.php

Timestamp:

07/13/2018 06:50:51 AM (7 years ago)

Author:

pento

Message:

REST API: Filter responses based on the _fields parameter, before data is processed.

Historically, the REST API would generate the entire response object, including running expensive filters, then it would apply the _fields parameter, discarding the fields that weren't specificed.

This change causes _fields to be applied earlier, so that only requested fields are processed.

Merges [43087] to the 4.9 branch.

Props danielbachhuber.
See #43874.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (1 diff)

branches/4.9/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -794 +794 @@
         $data = $response->get_data();
         $this->check_comment_data( $data, 'edit', $response->get_links() );
+    }
+
+    public function test_prepare_item_limit_fields() {
+        wp_set_current_user( self::$admin_id );
+        $endpoint = new WP_REST_Comments_Controller;
+        $request  = new WP_REST_Request( 'GET', sprintf( '/wp/v2/comments/%d', self::$approved_id ) );
+        $request->set_param( 'context', 'edit' );
+        $request->set_param( '_fields', 'id,status' );
+        $obj      = get_comment( self::$approved_id );
+        $response = $endpoint->prepare_item_for_response( $obj, $request );
+        $this->assertEquals( array(
+            'id',
+            'status',
+        ), array_keys( $response->get_data() ) );
     }