Changeset 43445 for branches/4.9/tests/phpunit/tests/rest-api/rest-controller.php

Timestamp:

07/13/2018 06:50:51 AM (7 years ago)

Author:

pento

Message:

REST API: Filter responses based on the _fields parameter, before data is processed.

Historically, the REST API would generate the entire response object, including running expensive filters, then it would apply the _fields parameter, discarding the fields that weren't specificed.

This change causes _fields to be applied earlier, so that only requested fields are processed.

Merges [43087] to the 4.9 branch.

Props danielbachhuber.
See #43874.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/rest-api/rest-controller.php (modified) (1 diff)

branches/4.9/tests/phpunit/tests/rest-api/rest-controller.php

@@ -191 +191 @@
         $this->assertEquals( 'a', $args['somedefault']['default'] );
     }
+
+    public function test_get_fields_for_response() {
+        $controller = new WP_REST_Test_Controller();
+        $request    = new WP_REST_Request( 'GET', '/wp/v2/testroute' );
+        $fields     = $controller->get_fields_for_response( $request );
+        $this->assertEquals( array(
+            'somestring',
+            'someinteger',
+            'someboolean',
+            'someurl',
+            'somedate',
+            'someemail',
+            'someenum',
+            'someargoptions',
+            'somedefault',
+        ), $fields );
+        $request->set_param( '_fields', 'somestring,someinteger' );
+        $fields = $controller->get_fields_for_response( $request );
+        $this->assertEquals( array(
+            'somestring',
+            'someinteger',
+        ), $fields );
+    }
 }