Changeset 43445 for branches/4.9/tests/phpunit/tests/rest-api/rest-revisions-controller.php

Timestamp:

07/13/2018 06:50:51 AM (8 years ago)

Author:

pento

Message:

REST API: Filter responses based on the _fields parameter, before data is processed.

Historically, the REST API would generate the entire response object, including running expensive filters, then it would apply the _fields parameter, discarding the fields that weren't specificed.

This change causes _fields to be applied earlier, so that only requested fields are processed.

Merges [43087] to the 4.9 branch.

Props danielbachhuber.
See #43874.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/rest-api/rest-revisions-controller.php (modified) (1 diff)

branches/4.9/tests/phpunit/tests/rest-api/rest-revisions-controller.php

@@ -224 +224 @@
     }
 
+    public function test_prepare_item_limit_fields() {
+        wp_set_current_user( self::$editor_id );
+        $request  = new WP_REST_Request( 'GET', '/wp/v2/posts/' . self::$post_id . '/revisions/' . $this->revision_id1 );
+        $endpoint = new WP_REST_Revisions_Controller( 'post' );
+        $request->set_param( 'context', 'edit' );
+        $request->set_param( '_fields', 'id,slug' );
+        $revision = get_post( $this->revision_id1 );
+        $response = $endpoint->prepare_item_for_response( $revision, $request );
+        $this->assertEquals( array(
+            'id',
+            'slug',
+        ), array_keys( $response->get_data() ) );
+    }
+
     public function test_get_item_schema() {
         $request = new WP_REST_Request( 'OPTIONS', '/wp/v2/posts/' . self::$post_id . '/revisions' );