Changeset 43481

Timestamp:

07/17/2018 02:39:59 PM (6 years ago)

Author:

azaozz

Message:

Customize: Do not attempt to count uncountable value.

Props dlh.
Merges [43480] to the 4.9 branch.
Fixes #44104.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• src/wp-includes/class-wp-customize-nav-menus.php (modified) (1 diff)
• tests/phpunit/tests/customize/nav-menus.php (modified) (1 diff)

branches/4.9/src/wp-includes/class-wp-customize-nav-menus.php

@@ -314 +314 @@
         // Prepend list of posts with nav_menus_created_posts search results on first page.
         $nav_menus_created_posts_setting = $this->manager->get_setting( 'nav_menus_created_posts' );
-        if ( 1 === $args['pagenum'] && $nav_menus_created_posts_setting && count( $nav_menus_created_posts_setting ) > 0 ) {
+        if ( 1 === $args['pagenum'] && $nav_menus_created_posts_setting && count( $nav_menus_created_posts_setting->value() ) > 0 ) {
             $stub_post_query = new WP_Query( array_merge(
                 $query,

branches/4.9/tests/phpunit/tests/customize/nav-menus.php

@@ -293 +293 @@
     function test_search_available_items_query() {
         $menus = new WP_Customize_Nav_Menus( $this->wp_customize );
+        do_action( 'customize_register', $this->wp_customize );
 
         // Create posts.