Changeset 43510 for branches/4.9/tests/phpunit/tests/rest-api/rest-post-meta-fields.php

Timestamp:

07/19/2018 06:48:52 PM (6 years ago)

Author:

kadamwhite

Message:

REST API: Support meta registration for specific object subtypes.

Introduce an object_subtype argument to the args array for register_meta() which can be used to limit meta registration to a single subtype (e.g. a custom post type or taxonomy, vs all posts or taxonomies).

Introduce register_post_meta() and register_term_meta() wrapper methods for register_meta to provide a convenient interface for the common case of registering meta for a specific taxonomy or post type. These methods work the way plugin developers have often expected register_meta to function, and should be used in place of direct register_meta where possible.

Props flixos90, tharsheblows, spacedmonkey.

Merges [43378] to the 4.9 branch.
Fixes #38323.

File:

• branches/4.9/tests/phpunit/tests/rest-api/rest-post-meta-fields.php (modified) (4 diffs)

branches/4.9/tests/phpunit/tests/rest-api/rest-post-meta-fields.php

@@ -13 +13 @@
     protected static $wp_meta_keys_saved;
     protected static $post_id;
+    protected static $cpt_post_id;
 
     public static function wpSetUpBeforeClass( $factory ) {
+        register_post_type( 'cpt', array(
+            'show_in_rest' => true,
+            'supports'     => array( 'custom-fields' ),
+        ) );
+
         self::$wp_meta_keys_saved = $GLOBALS['wp_meta_keys'];
         self::$post_id = $factory->post->create();
+        self::$cpt_post_id        = $factory->post->create( array( 'post_type' => 'cpt' ) );
     }
 
@@ -22 +29 @@
         $GLOBALS['wp_meta_keys'] = self::$wp_meta_keys_saved;
         wp_delete_post( self::$post_id, true );
+        wp_delete_post( self::$cpt_post_id, true );
+
+        unregister_post_type( 'cpt' );
     }
 
@@ -99 +109 @@
         ));
 
+        register_post_type( 'cpt', array(
+            'show_in_rest' => true,
+            'supports'     => array( 'custom-fields' ),
+        ) );
+
+        register_post_meta( 'cpt', 'test_cpt_single', array(
+            'show_in_rest'   => true,
+            'single'         => true,
+        ) );
+
+        register_post_meta( 'cpt', 'test_cpt_multi', array(
+            'show_in_rest'   => true,
+            'single'         => false,
+        ) );
+
+        // Register 'test_single' on subtype to override for bad auth.
+        register_post_meta( 'cpt', 'test_single', array(
+            'show_in_rest'   => true,
+            'single'         => true,
+            'auth_callback'  => '__return_false',
+        ) );
+
         /** @var WP_REST_Server $wp_rest_server */
         global $wp_rest_server;
@@ -1011 +1043 @@
 
     /**
+     * @ticket 38323
+     * @dataProvider data_get_subtype_meta_value
+     */
+    public function test_get_subtype_meta_value( $post_type, $meta_key, $single, $in_post_type ) {
+        $post_id  = self::$post_id;
+        $endpoint = 'posts';
+        if ( 'cpt' === $post_type ) {
+            $post_id  = self::$cpt_post_id;
+            $endpoint = 'cpt';
+        }
+
+        $meta_value = 'testvalue';
+
+        add_post_meta( $post_id, $meta_key, $meta_value );
+
+        $request = new WP_REST_Request( 'GET', sprintf( '/wp/v2/%s/%d', $endpoint, $post_id ) );
+        $response = rest_get_server()->dispatch( $request );
+
+        $this->assertEquals( 200, $response->get_status() );
+
+        $data = $response->get_data();
+
+        $this->assertArrayHasKey( 'meta', $data );
+        $this->assertInternalType( 'array', $data['meta'] );
+
+        if ( $in_post_type ) {
+            $expected_value = $meta_value;
+            if ( ! $single ) {
+                $expected_value = array( $expected_value );
+            }
+
+            $this->assertArrayHasKey( $meta_key, $data['meta'] );
+            $this->assertEquals( $expected_value, $data['meta'][ $meta_key ] );
+        } else {
+            $this->assertArrayNotHasKey( $meta_key, $data['meta'] );
+        }
+    }
+
+    public function data_get_subtype_meta_value() {
+        return array(
+            array( 'cpt', 'test_cpt_single', true, true ),
+            array( 'cpt', 'test_cpt_multi', false, true ),
+            array( 'cpt', 'test_single', true, true ),
+            array( 'cpt', 'test_multi', false, true ),
+            array( 'post', 'test_cpt_single', true, false ),
+            array( 'post', 'test_cpt_multi', false, false ),
+            array( 'post', 'test_single', true, true ),
+            array( 'post', 'test_multi', false, true ),
+        );
+    }
+
+    /**
+     * @ticket 38323
+     * @dataProvider data_set_subtype_meta_value
+     */
+    public function test_set_subtype_meta_value( $post_type, $meta_key, $single, $in_post_type, $can_write ) {
+        $post_id  = self::$post_id;
+        $endpoint = 'posts';
+        if ( 'cpt' === $post_type ) {
+            $post_id  = self::$cpt_post_id;
+            $endpoint = 'cpt';
+        }
+
+        $meta_value = 'value_to_set';
+
+        $this->grant_write_permission();
+
+        $request = new WP_REST_Request( 'POST', sprintf( '/wp/v2/%s/%d', $endpoint, $post_id ) );
+        $request->set_body_params( array(
+            'meta' => array(
+                $meta_key => $meta_value,
+            ),
+        ) );
+
+        $response = rest_get_server()->dispatch( $request );
+        if ( ! $can_write ) {
+            $this->assertEquals( 403, $response->get_status() );
+            $this->assertEmpty( get_post_meta( $post_id, $meta_key, $single ) );
+            return;
+        }
+
+        $this->assertEquals( 200, $response->get_status() );
+
+        $data = $response->get_data();
+        $this->assertArrayHasKey( 'meta', $data );
+        $this->assertInternalType( 'array', $data['meta'] );
+
+        if ( $in_post_type ) {
+            $expected_value = $meta_value;
+            if ( ! $single ) {
+                $expected_value = array( $expected_value );
+            }
+
+            $this->assertEquals( $expected_value, get_post_meta( $post_id, $meta_key, $single ) );
+            $this->assertArrayHasKey( $meta_key, $data['meta'] );
+            $this->assertEquals( $expected_value, $data['meta'][ $meta_key ] );
+        } else {
+            $this->assertEmpty( get_post_meta( $post_id, $meta_key, $single ) );
+            $this->assertArrayNotHasKey( $meta_key, $data['meta'] );
+        }
+    }
+
+    public function data_set_subtype_meta_value() {
+        $data = $this->data_get_subtype_meta_value();
+
+        foreach ( $data as $index => $dataset ) {
+            $can_write = true;
+
+            // This combination is not writable because of an auth callback of '__return_false'.
+            if ( 'cpt' === $dataset[0] && 'test_single' === $dataset[1] ) {
+                $can_write = false;
+            }
+
+            $data[ $index ][] = $can_write;
+        }
+
+        return $data;
+    }
+
+    /**
      * Internal function used to disable an insert query which
      * will trigger a wpdb error for testing purposes.