WordPress.org

Make WordPress Core

Changeset 43531 for trunk


Ignore:
Timestamp:
07/24/2018 05:05:56 PM (2 years ago)
Author:
SergeyBiryukov
Message:

Privacy: Revert [43525].

The commenter cookies checkbox is not legally required, so should be disabled by default.

Fixes #44373.

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/schema.php

    r43525 r43531  
    536536        // 4.9.6
    537537        'wp_page_for_privacy_policy'      => 0,
     538
     539        // 4.9.8
     540        'show_comments_cookies_opt_in'    => 0,
    538541    );
    539542
  • trunk/src/wp-admin/options-discussion.php

    r43525 r43531  
    8686</label>
    8787<br />
     88
     89<label for="show_comments_cookies_opt_in">
     90<input name="show_comments_cookies_opt_in" type="checkbox" id="show_comments_cookies_opt_in" value="1" <?php checked( '1', get_option( 'show_comments_cookies_opt_in' ) ); ?> />
     91<?php _e( 'Show comments cookies opt-in checkbox.' ); ?>
     92</label>
     93<br />
     94
    8895<label for="thread_comments">
    8996<input name="thread_comments" type="checkbox" id="thread_comments" value="1" <?php checked( '1', get_option( 'thread_comments' ) ); ?> />
  • trunk/src/wp-admin/options.php

    r43525 r43531  
    117117        'comment_order',
    118118        'comment_registration',
     119        'show_comments_cookies_opt_in',
    119120    ),
    120121    'media' => array(
  • trunk/src/wp-includes/comment-template.php

    r43525 r43531  
    22722272    );
    22732273
    2274     if ( has_action( 'set_comment_cookies', 'wp_set_comment_cookies' ) ) {
     2274    if ( has_action( 'set_comment_cookies', 'wp_set_comment_cookies' ) && get_option( 'show_comments_cookies_opt_in' ) ) {
    22752275        $consent           = empty( $commenter['comment_author_email'] ) ? '' : ' checked="checked"';
    22762276        $fields['cookies'] = '<p class="comment-form-cookies-consent"><input id="wp-comment-cookies-consent" name="wp-comment-cookies-consent" type="checkbox" value="yes"' . $consent . ' />' .
  • trunk/tests/phpunit/tests/comment/commentForm.php

    r43525 r43531  
    8888        $p = self::factory()->post->create();
    8989
     90        add_filter( 'option_show_comments_cookies_opt_in', '__return_true' );
     91
    9092        $args = array(
    9193            'fields' => array(
     
    9597        $form = get_echo( 'comment_form', array( $args, $p ) );
    9698
     99        remove_filter( 'option_show_comments_cookies_opt_in', '__return_true' );
     100
    97101        $this->assertRegExp( '|<p class="comment\-form\-cookies\-consent">.*?</p>|', $form );
    98102    }
Note: See TracChangeset for help on using the changeset viewer.