Changeset 43537

Timestamp:

07/26/2018 03:05:40 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Dashboard: Tweak the "Try Gutenberg" callout:

• Introduce try_gutenberg_learn_more_link filter that allows hosts or site owners to change the link, to provide extra information about Gutenberg, specific to their service.
• Only display the "Install" buttons if we're able to directly write to disk to install the plugins.
• Make sure the "Dismiss" link works correctly.

Props pento, andrew.taylor, leemon.
Fixes #41316.

Location:

branches/4.9/src/wp-admin

Files:

• admin-ajax.php (modified) (1 diff)
• includes/dashboard.php (modified) (3 diffs)

branches/4.9/src/wp-admin/admin-ajax.php

@@ -68 +68 @@
     'wp-privacy-export-personal-data',
     'wp-privacy-erase-personal-data',
+    'update-try-gutenberg-panel',
 );
 

branches/4.9/src/wp-admin/includes/dashboard.php

@@ -1633 +1633 @@
     if ( current_user_can( 'install_plugins' ) ) {
         if ( empty( $plugins['gutenberg/gutenberg.php'] ) ) {
-            $action = __( 'Install Gutenberg' );
-            $url = wp_nonce_url( self_admin_url( 'update.php?action=install-plugin&plugin=gutenberg' ), 'install-plugin_gutenberg' );
-            $classes = ' install-now';
+            if ( get_filesystem_method( array(), WP_PLUGIN_DIR ) === 'direct' ) {
+                $action = __( 'Install Gutenberg' );
+                $url = wp_nonce_url( self_admin_url( 'update.php?action=install-plugin&plugin=gutenberg' ), 'install-plugin_gutenberg' );
+                $classes = ' install-now';
+            }
         } else if ( is_plugin_inactive( 'gutenberg/gutenberg.php' ) ) {
             $action = __( 'Activate Gutenberg' );
@@ -1643 +1645 @@
 
         if ( empty( $plugins['classic-editor/classic-editor.php'] ) ) {
-            $classic_action = __( 'Install the Classic Editor' );
-            $classic_url = wp_nonce_url( self_admin_url( 'update.php?action=install-plugin&plugin=classic-editor' ), 'install-plugin_classic-editor' );
-            $classic_classes = ' install-now';
+            if ( get_filesystem_method( array(), WP_PLUGIN_DIR ) === 'direct' ) {
+                $classic_action = __( 'Install the Classic Editor' );
+                $classic_url = wp_nonce_url( self_admin_url( 'update.php?action=install-plugin&plugin=classic-editor' ), 'install-plugin_classic-editor' );
+                $classic_classes = ' install-now';
+            }
         } else if ( is_plugin_inactive( 'classic-editor/classic-editor.php' ) ) {
             $classic_action = __( 'Activate the Classic Editor' );
@@ -1696 +1700 @@
                 </div>
 
+                <div class="try-gutenberg-action">
                     <?php if ( $action ) { ?>
-                        <div class="try-gutenberg-action">
-                            <p><a class="button button-primary button-hero<?php echo $classes; ?>" href="<?php echo esc_url( $url ); ?>" data-name="<?php esc_attr_e( 'Gutenberg' ); ?>" data-slug="gutenberg"><?php echo $action; ?></a></p>
-                            <p>
-                                <?php
-                                    printf(
-                                        /* translators: Link to https://wordpress.org/gutenberg/ */
-                                        __( '<a href="%s">Learn more about Gutenberg</a>' ),
-                                        __( 'https://wordpress.org/gutenberg/' )
-                                    );
-                                ?>
-                            </p>
-                        </div>
+                        <p><a class="button button-primary button-hero<?php echo $classes; ?>" href="<?php echo esc_url( $url ); ?>" data-name="<?php esc_attr_e( 'Gutenberg' ); ?>" data-slug="gutenberg"><?php echo $action; ?></a></p>
                     <?php } ?>
+
+                    <p>
+                        <?php
+                            $learnmore = sprintf(
+                                /* translators: Link to https://wordpress.org/gutenberg/ */
+                                __( '<a href="%s">Learn more about Gutenberg</a>' ),
+                                __( 'https://wordpress.org/gutenberg/' )
+                            );
+
+                            /**
+                             * Filters the "Learn more" link in the Try Gutenberg panel.
+                             *
+                             * It allows hosts or site owners to change the link, to provide extra
+                             * information about Gutenberg, specific to their service.
+                             *
+                             * WARNING: This filter will only exist in the 4.9.x series, it will not be
+                             * added to WordPress 5.0 and later.
+                             *
+                             * @since 4.9.8
+                             */
+                            echo apply_filters( 'try_gutenberg_learn_more_link', $learnmore );
+                        ?>
+                    </p>
+                </div>
             </div>