Changeset 43569 for trunk/src/wp-admin/includes/file.php

Timestamp:

08/15/2018 06:22:00 AM (8 years ago)

Author:

pento

Message:

Coding Standards: Prepare for upgrading WPCS to 1.0.0.

In order to get the best result when running phpcbf across the codebase, there are some manual tweaks we need to make.

These fall into three categories:

• Fixing incorrectly indented code which has flow-on effects when auto-fixing.
• Tweaking the layout of inline PHP inside HTML tags.
• Moving more complex inline PHP inside HTML tags, to execute earlier.

See #44600.

File:

• trunk/src/wp-admin/includes/file.php (modified) (2 diffs)

trunk/src/wp-admin/includes/file.php

@@ -1818 +1818 @@
         _e( 'If you do not remember your credentials, you should contact your web host.' );
 
+        $hostname_value = esc_attr( $hostname );
+        if ( ! empty( $port ) ) {
+                $hostname_value .= ":$port";
+        }
+
         $password_value = '';
-if ( defined( 'FTP_PASS' ) ) {
-        $password_value = '*****';
-}
+        if ( defined( 'FTP_PASS' ) ) {
+                $password_value = '*****';
+        }
 ?>
 </p>
 <label for="hostname">
         <span class="field-title"><?php _e( 'Hostname' ); ?></span>
-        <input name="hostname" type="text" id="hostname" aria-describedby="request-filesystem-credentials-desc" class="code" placeholder="<?php esc_attr_e( 'example: www.wordpress.org' ); ?>" value="
-                                                                                                                                                                                                                                                                                                                <?php
-                                                                                                                                                                                                                                                                                                                echo esc_attr( $hostname );
-                                                                                                                                                                                                                                                                                                                if ( ! empty( $port ) ) {
-                                                                                                                                                                                                                                                                                                                        echo ":$port";}
-?>
-"<?php disabled( defined( 'FTP_HOST' ) ); ?> />
+        <input name="hostname" type="text" id="hostname" aria-describedby="request-filesystem-credentials-desc" class="code" placeholder="<?php esc_attr_e( 'example: www.wordpress.org' ); ?>" value="<?php echo $hostname_value; ?>"<?php disabled( defined( 'FTP_HOST' ) ); ?> />
 </label>
 <div class="ftp-username">
@@ -1859 +1858 @@
         ?>
         <label for="<?php echo esc_attr( $name ); ?>">
-                <input type="radio" name="connection_type" id="<?php echo esc_attr( $name ); ?>" value="<?php echo esc_attr( $name ); ?>"
-                                                                                                                                        <?php
-                                                                                                                                        checked( $name, $connection_type );
-                                                                                                                                        echo $disabled;
-?>
- />
+                <input type="radio" name="connection_type" id="<?php echo esc_attr( $name ); ?>" value="<?php echo esc_attr( $name ); ?>" <?php checked( $name, $connection_type ); ?> <?php echo $disabled; ?> />
                 <?php echo $text; ?>
         </label>