Changeset 43569 for trunk/src/wp-admin/includes/meta-boxes.php

Timestamp:

08/15/2018 06:22:00 AM (6 years ago)

Author:

pento

Message:

Coding Standards: Prepare for upgrading WPCS to 1.0.0.

In order to get the best result when running phpcbf across the codebase, there are some manual tweaks we need to make.

These fall into three categories:

• Fixing incorrectly indented code which has flow-on effects when auto-fixing.
• Tweaking the layout of inline PHP inside HTML tags.
• Moving more complex inline PHP inside HTML tags, to execute earlier.

See #44600.

File:

• trunk/src/wp-admin/includes/meta-boxes.php (modified) (2 diffs)

trunk/src/wp-admin/includes/meta-boxes.php

@@ -758 +758 @@
 <p class="meta-options">
     <label for="comment_status" class="selectit"><input name="comment_status" type="checkbox" id="comment_status" value="open" <?php checked( $post->comment_status, 'open' ); ?> /> <?php _e( 'Allow comments' ); ?></label><br />
-    <label for="ping_status" class="selectit"><input name="ping_status" type="checkbox" id="ping_status" value="open" <?php checked( $post->ping_status, 'open' ); ?> /> 
-                                                                                                                                                        <?php
-                                                                                                                                                        printf(
-                                                                                                                                                            /* translators: %s: Codex URL */
-                                                                                                                                                            __( 'Allow <a href="%s">trackbacks and pingbacks</a> on this page' ),
-                                                                                                                                                            __( 'https://codex.wordpress.org/Introduction_to_Blogging#Managing_Comments' )
-                                                                                                                                                        );
+    <label for="ping_status" class="selectit"><input name="ping_status" type="checkbox" id="ping_status" value="open" <?php checked( $post->ping_status, 'open' ); ?> />
+        <?php
+        printf(
+            /* translators: %s: Codex URL */
+            __( 'Allow <a href="%s">trackbacks and pingbacks</a> on this page' ),
+            __( 'https://codex.wordpress.org/Introduction_to_Blogging#Managing_Comments' )
+        );
         ?>
-        </label>
+    </label>
     <?php
     /**
@@ -1351 +1351 @@
 
     foreach ( wp_get_attachment_id3_keys( $post, 'edit' ) as $key => $label ) :
+        $value = '';
+        if ( ! empty( $meta[ $key ] ) ) {
+            $value = $meta[ $key ];
+        }
     ?>
     <p>
         <label for="title"><?php echo $label; ?></label><br />
-        <input type="text" name="id3_<?php echo esc_attr( $key ); ?>" id="id3_<?php echo esc_attr( $key ); ?>" class="large-text" value="
-                                                <?php
-                                                if ( ! empty( $meta[ $key ] ) ) {
-                                                    echo esc_attr( $meta[ $key ] );
-                                                }
-        ?>
-        " />
+        <input type="text" name="id3_<?php echo esc_attr( $key ); ?>" id="id3_<?php echo esc_attr( $key ); ?>" class="large-text" value="<?php echo esc_attr( $value ); ?>" />
     </p>
     <?php