Changeset 43569 for trunk/src/wp-admin/nav-menus.php

Timestamp:

08/15/2018 06:22:00 AM (6 years ago)

Author:

pento

Message:

Coding Standards: Prepare for upgrading WPCS to 1.0.0.

In order to get the best result when running phpcbf across the codebase, there are some manual tweaks we need to make.

These fall into three categories:

• Fixing incorrectly indented code which has flow-on effects when auto-fixing.
• Tweaking the layout of inline PHP inside HTML tags.
• Moving more complex inline PHP inside HTML tags, to execute earlier.

See #44600.

File:

• trunk/src/wp-admin/nav-menus.php (modified) (7 diffs)

trunk/src/wp-admin/nav-menus.php

@@ -629 +629 @@
     <h2 class="nav-tab-wrapper wp-clearfix">
         <a href="<?php echo admin_url( 'nav-menus.php' ); ?>" class="nav-tab<?php echo $nav_tab_active_class; ?>"><?php esc_html_e( 'Edit Menus' ); ?></a>
-        <?php if ( $num_locations && $menu_count ) : ?>
-            <a href="<?php echo esc_url( add_query_arg( array( 'action' => 'locations' ), admin_url( 'nav-menus.php' ) ) ); ?>" class="nav-tab
-                                <?php
-                                if ( $locations_screen ) {
-                                    echo ' nav-tab-active';}
-?>
-"><?php esc_html_e( 'Manage Locations' ); ?></a>
         <?php
-            endif;
+        if ( $num_locations && $menu_count ) {
+            $active_tab_class = '';
+            if ( $locations_screen ) {
+                $active_tab_class = ' nav-tab-active';
+            }
+            ?>
+            <a href="<?php echo esc_url( add_query_arg( array( 'action' => 'locations' ), admin_url( 'nav-menus.php' ) ) ); ?>" class="nav-tab<?php echo $active_tab_class; ?>"><?php esc_html_e( 'Manage Locations' ); ?></a>
+            <?php
+        }
         ?>
     </h2>
@@ -695 +696 @@
                                         )
                                     );
-?>
-">
+                                    ?>
+                                    ">
                                         <span aria-hidden="true"><?php _ex( 'Edit', 'menu' ); ?></span><span class="screen-reader-text"><?php _e( 'Edit selected menu' ); ?></span>
                                     </a>
@@ -713 +714 @@
                                         )
                                     );
-?>
-">
+                                    ?>
+                                    ">
                                         <?php _ex( 'Use new menu', 'menu' ); ?>
                                     </a>
@@ -819 +820 @@
 
         $metabox_holder_disabled_class = '';
-if ( isset( $_GET['menu'] ) && '0' == $_GET['menu'] ) {
-    $metabox_holder_disabled_class = ' metabox-holder-disabled';
-}
+        if ( isset( $_GET['menu'] ) && '0' == $_GET['menu'] ) {
+            $metabox_holder_disabled_class = ' metabox-holder-disabled';
+        }
     ?>
     </div><!-- /manage-menus -->
@@ -843 +844 @@
             <?php
                 $new_screen_class = '';
-            if ( $add_new_screen ) {
-                $new_screen_class = 'blank-slate';
-            }
+                if ( $add_new_screen ) {
+                    $new_screen_class = 'blank-slate';
+                }
             ?>
                 <h2><?php _e( 'Menu structure' ); ?></h2>
@@ -907 +908 @@
 
                                 $no_menus_style = '';
-if ( $one_theme_location_no_menus ) {
-    $no_menus_style = 'style="display: none;"';
-}
+                                if ( $one_theme_location_no_menus ) {
+                                    $no_menus_style = 'style="display: none;"';
+                                }
                             ?>
                             <div class="menu-settings" <?php echo $no_menus_style; ?>>
@@ -977 +978 @@
                                     )
                                 );
-?>
-"><?php _e( 'Delete Menu' ); ?></a>
+                                ?>
+                                "><?php _e( 'Delete Menu' ); ?></a>
                             </span><!-- END .delete-action -->
                             <?php endif; ?>