Changeset 43569 for trunk/src/wp-admin/update-core.php

Timestamp:

08/15/2018 06:22:00 AM (8 years ago)

Author:

pento

Message:

Coding Standards: Prepare for upgrading WPCS to 1.0.0.

In order to get the best result when running phpcbf across the codebase, there are some manual tweaks we need to make.

These fall into three categories:

• Fixing incorrectly indented code which has flow-on effects when auto-fixing.
• Tweaking the layout of inline PHP inside HTML tags.
• Moving more complex inline PHP inside HTML tags, to execute earlier.

See #44600.

File:

• trunk/src/wp-admin/update-core.php (modified) (2 diffs)

trunk/src/wp-admin/update-core.php

@@ -311 +311 @@
                         <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $plugin_file ); ?>" />
                         <label for="<?php echo $checkbox_id; ?>" class="screen-reader-text">
-                                                                                <?php
-                                                                                /* translators: %s: plugin name */
-                                                                                printf(
-                                                                                        __( 'Select %s' ),
-                                                                                        $plugin_data->Name
-                                                                                );
-                                ?>
-                                </label>
-                        </td>
-                        <td class="plugin-title"><p>
-                                <?php echo $icon; ?>
-                                <strong><?php echo $plugin_data->Name; ?></strong>
-                                <?php
-                                /* translators: 1: plugin version, 2: new version */
+                        <?php
+                                /* translators: %s: plugin name */
                                 printf(
-                                        __( 'You have version %1$s installed. Update to %2$s.' ),
-                                        $plugin_data->Version,
-                                        $plugin_data->update->new_version
+                                        __( 'Select %s' ),
+                                        $plugin_data->Name
                                 );
-                                echo ' ' . $details . $compat . $upgrade_notice;
                         ?>
-                        </p></td>
-                </tr>
+                        </label>
+                </td>
+                <td class="plugin-title"><p>
+                        <?php echo $icon; ?>
+                        <strong><?php echo $plugin_data->Name; ?></strong>
+                        <?php
+                        /* translators: 1: plugin version, 2: new version */
+                        printf(
+                                __( 'You have version %1$s installed. Update to %2$s.' ),
+                                $plugin_data->Version,
+                                $plugin_data->update->new_version
+                        );
+                        echo ' ' . $details . $compat . $upgrade_notice;
+                ?>
+                </p></td>
+        </tr>
                 <?php
 }
@@ -387 +387 @@
                         <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $stylesheet ); ?>" />
                         <label for="<?php echo $checkbox_id; ?>" class="screen-reader-text">
-                                                                                <?php
-                                                                                /* translators: %s: theme name */
-                                                                                printf(
-                                                                                        __( 'Select %s' ),
-                                                                                        $theme->display( 'Name' )
-                                                                                );
-                                ?>
-                                </label>
-                        </td>
-                        <td class="plugin-title"><p>
-                                <img src="<?php echo esc_url( $theme->get_screenshot() ); ?>" width="85" height="64" class="updates-table-screenshot" alt="" />
-                                <strong><?php echo $theme->display( 'Name' ); ?></strong>
-                                <?php
-                                /* translators: 1: theme version, 2: new version */
+                        <?php
+                                /* translators: %s: theme name */
                                 printf(
-                                        __( 'You have version %1$s installed. Update to %2$s.' ),
-                                        $theme->display( 'Version' ),
-                                        $theme->update['new_version']
+                                        __( 'Select %s' ),
+                                        $theme->display( 'Name' )
                                 );
                         ?>
-                        </p></td>
-                </tr>
+                        </label>
+                </td>
+                <td class="plugin-title"><p>
+                        <img src="<?php echo esc_url( $theme->get_screenshot() ); ?>" width="85" height="64" class="updates-table-screenshot" alt="" />
+                        <strong><?php echo $theme->display( 'Name' ); ?></strong>
+                        <?php
+                        /* translators: 1: theme version, 2: new version */
+                        printf(
+                                __( 'You have version %1$s installed. Update to %2$s.' ),
+                                $theme->display( 'Version' ),
+                                $theme->update['new_version']
+                        );
+                ?>
+                </p></td>
+        </tr>
                 <?php
 }