Changeset 43571 for trunk/src/wp-admin/includes/class-theme-upgrader.php

Timestamp:

08/17/2018 01:50:26 AM (6 years ago)

Author:

pento

Message:

Coding Standards: Upgrade WPCS to 1.0.0

WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:

• Multiline function calls must now put each parameter on a new line.
• Auto-formatting files is now part of the grunt precommit script.
• Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.

File:

• trunk/src/wp-admin/includes/class-theme-upgrader.php (modified) (6 diffs)

trunk/src/wp-admin/includes/class-theme-upgrader.php

@@ -112 +112 @@
         // We don't have the parent theme, let's install it.
         $api = themes_api(
-            'theme_information', array(
+            'theme_information',
+            array(
                 'slug'   => $theme_info->get( 'Template' ),
                 'fields' => array(
@@ -419 +420 @@
         /** This action is documented in wp-admin/includes/class-wp-upgrader.php */
         do_action(
-            'upgrader_process_complete', $this, array(
+            'upgrader_process_complete',
+            $this,
+            array(
                 'action' => 'update',
                 'type'   => 'theme',
@@ -469 +472 @@
         if ( ! file_exists( $working_directory . 'style.css' ) ) {
             return new WP_Error(
-                'incompatible_archive_theme_no_style', $this->strings['incompatible_archive'],
+                'incompatible_archive_theme_no_style',
+                $this->strings['incompatible_archive'],
                 /* translators: %s: style.css */
                 sprintf(
@@ -479 +483 @@
 
         $info = get_file_data(
-            $working_directory . 'style.css', array(
+            $working_directory . 'style.css',
+            array(
                 'Name'     => 'Theme Name',
                 'Template' => 'Template',
@@ -487 +492 @@
         if ( empty( $info['Name'] ) ) {
             return new WP_Error(
-                'incompatible_archive_theme_no_name', $this->strings['incompatible_archive'],
+                'incompatible_archive_theme_no_name',
+                $this->strings['incompatible_archive'],
                 /* translators: %s: style.css */
                 sprintf(
@@ -499 +505 @@
         if ( empty( $info['Template'] ) && ! file_exists( $working_directory . 'index.php' ) ) {
             return new WP_Error(
-                'incompatible_archive_theme_no_index', $this->strings['incompatible_archive'],
+                'incompatible_archive_theme_no_index',
+                $this->strings['incompatible_archive'],
                 /* translators: %s: index.php */
                 sprintf(