Changeset 43571 for trunk/src/wp-admin/includes/class-wp-screen.php

Timestamp:

08/17/2018 01:50:26 AM (6 years ago)

Author:

pento

Message:

Coding Standards: Upgrade WPCS to 1.0.0

WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:

• Multiline function calls must now put each parameter on a new line.
• Auto-formatting files is now part of the grunt precommit script.
• Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.

File:

• trunk/src/wp-admin/includes/class-wp-screen.php (modified) (7 diffs)

trunk/src/wp-admin/includes/class-wp-screen.php

@@ -807 +807 @@
                                 </a>
                             </li>
-                        <?php
+                            <?php
                             $class = '';
                         endforeach;
@@ -838 +838 @@
                                 ?>
                             </div>
-                        <?php
+                            <?php
                             $classes = 'help-tab-content';
                         endforeach;
@@ -891 +891 @@
             <button type="button" id="contextual-help-link" class="button show-settings" aria-controls="contextual-help-wrap" aria-expanded="false"><?php _e( 'Help' ); ?></button>
             </div>
-        <?php
+            <?php
         endif;
 if ( $this->show_screen_options() ) :
-        ?>
+    ?>
             <div id="screen-options-link-wrap" class="hide-if-no-js screen-meta-toggle">
             <button type="button" id="show-settings-link" class="button show-settings" aria-controls="screen-options-wrap" aria-expanded="false"><?php _e( 'Screen Options' ); ?></button>
@@ -969 +969 @@
     public function render_screen_options( $options = array() ) {
         $options = wp_parse_args(
-            $options, array(
+            $options,
+            array(
                 'wrap' => true,
             )
@@ -1122 +1123 @@
                                                     <label class="columns-prefs-<?php echo $i; ?>">
                 <input type='radio' name='screen_columns' value='<?php echo esc_attr( $i ); ?>'
-                    <?php checked( $screen_layout_columns, $i ); ?> />
-                <?php printf( _n( '%s column', '%s columns', $i ), number_format_i18n( $i ) ); ?>
+                                                    <?php checked( $screen_layout_columns, $i ); ?> />
+                                                    <?php printf( _n( '%s column', '%s columns', $i ), number_format_i18n( $i ) ); ?>
                 </label>
-                <?php
+                                                    <?php
             endfor;
-            ?>
+                                                ?>
         </fieldset>
         <?php
@@ -1236 +1237 @@
         // This needs a submit button
         add_filter( 'screen_options_show_submit', '__return_true' );
-?>
+        ?>
         <fieldset class="metabox-prefs view-mode">
         <legend><?php _e( 'View Mode' ); ?></legend>
@@ -1248 +1249 @@
                 </label>
         </fieldset>
-<?php
+        <?php
     }