Changeset 43571 for trunk/src/wp-admin/options-writing.php

Timestamp:

08/17/2018 01:50:26 AM (6 years ago)

Author:

pento

Message:

Coding Standards: Upgrade WPCS to 1.0.0

WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:

• Multiline function calls must now put each parameter on a new line.
• Auto-formatting files is now part of the grunt precommit script.
• Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.

File:

• trunk/src/wp-admin/options-writing.php (modified) (7 diffs)

trunk/src/wp-admin/options-writing.php

@@ -70 +70 @@
 <label for="use_smilies">
 <input name="use_smilies" type="checkbox" id="use_smilies" value="1" <?php checked( '1', get_option( 'use_smilies' ) ); ?> />
-<?php _e( 'Convert emoticons like <code>:-)</code> and <code>:-P</code> to graphics on display' ); ?></label><br />
+    <?php _e( 'Convert emoticons like <code>:-)</code> and <code>:-P</code> to graphics on display' ); ?></label><br />
 <label for="use_balanceTags"><input name="use_balanceTags" type="checkbox" id="use_balanceTags" value="1" <?php checked( '1', get_option( 'use_balanceTags' ) ); ?> /> <?php _e( 'WordPress should correct invalidly nested XHTML automatically' ); ?></label>
 </fieldset></td>
@@ -108 +108 @@
 <?php
 if ( get_option( 'link_manager_enabled' ) ) :
-?>
+    ?>
 <tr>
 <th scope="row"><label for="default_link_category"><?php _e( 'Default Link Category' ); ?></label></th>
 <td>
-<?php
-wp_dropdown_categories(
-    array(
-        'hide_empty'   => 0,
-        'name'         => 'default_link_category',
-        'orderby'      => 'name',
-        'selected'     => get_option( 'default_link_category' ),
-        'hierarchical' => true,
-        'taxonomy'     => 'link_category',
-    )
-);
-?>
+    <?php
+    wp_dropdown_categories(
+        array(
+            'hide_empty'   => 0,
+            'name'         => 'default_link_category',
+            'orderby'      => 'name',
+            'selected'     => get_option( 'default_link_category' ),
+            'hierarchical' => true,
+            'taxonomy'     => 'link_category',
+        )
+    );
+    ?>
 </td>
 </tr>
@@ -137 +137 @@
 /** This filter is documented in wp-admin/options.php */
 if ( apply_filters( 'enable_post_by_email_configuration', true ) ) {
-?>
+    ?>
 <h2 class="title"><?php _e( 'Post via email' ); ?></h2>
 <p>
-<?php
-printf(
-    /* translators: 1, 2, 3: examples of random email addresses */
-    __( 'To post to WordPress by email you must set up a secret email account with POP3 access. Any mail received at this address will be posted, so it&#8217;s a good idea to keep this address very secret. Here are three random strings you could use: %1$s, %2$s, %3$s.' ),
-    sprintf( '<kbd>%s</kbd>', wp_generate_password( 8, false ) ),
-    sprintf( '<kbd>%s</kbd>', wp_generate_password( 8, false ) ),
-    sprintf( '<kbd>%s</kbd>', wp_generate_password( 8, false ) )
-);
-?>
+    <?php
+    printf(
+        /* translators: 1, 2, 3: examples of random email addresses */
+        __( 'To post to WordPress by email you must set up a secret email account with POP3 access. Any mail received at this address will be posted, so it&#8217;s a good idea to keep this address very secret. Here are three random strings you could use: %1$s, %2$s, %3$s.' ),
+        sprintf( '<kbd>%s</kbd>', wp_generate_password( 8, false ) ),
+        sprintf( '<kbd>%s</kbd>', wp_generate_password( 8, false ) ),
+        sprintf( '<kbd>%s</kbd>', wp_generate_password( 8, false ) )
+    );
+    ?>
 </p>
 
@@ -172 +172 @@
 <th scope="row"><label for="default_email_category"><?php _e( 'Default Mail Category' ); ?></label></th>
 <td>
-<?php
-wp_dropdown_categories(
-    array(
-        'hide_empty'   => 0,
-        'name'         => 'default_email_category',
-        'orderby'      => 'name',
-        'selected'     => get_option( 'default_email_category' ),
-        'hierarchical' => true,
-    )
-);
-?>
-</td>
-</tr>
-<?php do_settings_fields( 'writing', 'post_via_email' ); ?>
+    <?php
+    wp_dropdown_categories(
+        array(
+            'hide_empty'   => 0,
+            'name'         => 'default_email_category',
+            'orderby'      => 'name',
+            'selected'     => get_option( 'default_email_category' ),
+            'hierarchical' => true,
+        )
+    );
+    ?>
+</td>
+</tr>
+    <?php do_settings_fields( 'writing', 'post_via_email' ); ?>
 </table>
 <?php } ?>
@@ -198 +198 @@
  */
 if ( apply_filters( 'enable_update_services_configuration', true ) ) {
-?>
+    ?>
 <h2 class="title"><?php _e( 'Update Services' ); ?></h2>
 
-<?php if ( 1 == get_option( 'blog_public' ) ) : ?>
+    <?php if ( 1 == get_option( 'blog_public' ) ) : ?>
 
     <p><label for="ping_sites">
-    <?php
+        <?php
         printf(
             /* translators: %s: Codex URL */
@@ -210 +210 @@
             __( 'https://codex.wordpress.org/Update_Services' )
         );
-    ?>
+        ?>
     </label></p>
 
     <textarea name="ping_sites" id="ping_sites" class="large-text code" rows="3"><?php echo esc_textarea( get_option( 'ping_sites' ) ); ?></textarea>
 
-<?php else : ?>
+    <?php else : ?>
 
     <p>
-    <?php
+        <?php
         printf(
             /* translators: 1: Codex URL, 2: Reading Settings URL */
@@ -225 +225 @@
             'options-reading.php'
         );
-    ?>
+        ?>
     </p>
 
-<?php endif; ?>
+    <?php endif; ?>
 <?php } // enable_update_services_configuration ?>