Changeset 43571 for trunk/src/wp-admin/themes.php

Timestamp:

08/17/2018 01:50:26 AM (6 years ago)

Author:

pento

Message:

Coding Standards: Upgrade WPCS to 1.0.0

WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:

• Multiline function calls must now put each parameter on a new line.
• Auto-formatting files is now part of the grunt precommit script.
• Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.

File:

• trunk/src/wp-admin/themes.php (modified) (9 diffs)

trunk/src/wp-admin/themes.php

@@ -134 +134 @@
 
 wp_localize_script(
-    'theme', '_wpThemeSettings', array(
+    'theme',
+    '_wpThemeSettings',
+    array(
         'themes'   => $themes,
         'settings' => array(
@@ -173 +175 @@
 <?php
 if ( ! validate_current_theme() || isset( $_GET['broken'] ) ) :
-?>
+    ?>
 <div id="message1" class="updated notice is-dismissible"><p><?php _e( 'The active theme is broken. Reverting to the default theme.' ); ?></p></div>
-<?php
+    <?php
 elseif ( isset( $_GET['activated'] ) ) :
     if ( isset( $_GET['previewed'] ) ) {
@@ -185 +187 @@
 }
     elseif ( isset( $_GET['deleted'] ) ) :
-    ?>
+        ?>
 <div id="message3" class="updated notice is-dismissible"><p><?php _e( 'Theme deleted.' ); ?></p></div>
 <?php elseif ( isset( $_GET['delete-active-child'] ) ) : ?>
     <div id="message4" class="error"><p><?php _e( 'You cannot delete a theme while it has an active child theme.' ); ?></p></div>
-<?php
+    <?php
 endif;
 
@@ -336 +338 @@
 // List broken themes, if any.
 if ( ! is_multisite() && current_user_can( 'edit_themes' ) && $broken_themes = wp_get_themes( array( 'errors' => true ) ) ) {
-?>
+    ?>
 
 <div class="broken-themes">
@@ -342 +344 @@
 <p><?php _e( 'The following themes are installed but incomplete.' ); ?></p>
 
-<?php
-$can_delete  = current_user_can( 'delete_themes' );
-$can_install = current_user_can( 'install_themes' );
-?>
+    <?php
+    $can_delete  = current_user_can( 'delete_themes' );
+    $can_install = current_user_can( 'install_themes' );
+    ?>
 <table>
     <tr>
@@ -368 +370 @@
                         'action'     => 'delete',
                         'stylesheet' => urlencode( $stylesheet ),
-                    ), admin_url( 'themes.php' )
+                    ),
+                    admin_url( 'themes.php' )
                 );
                 $delete_url = wp_nonce_url( $delete_url, 'delete-theme_' . $stylesheet );
@@ -385 +388 @@
                             'action' => 'install-theme',
                             'theme'  => urlencode( $parent_theme_name ),
-                        ), admin_url( 'update.php' )
+                        ),
+                        admin_url( 'update.php' )
                     );
                     $install_url = wp_nonce_url( $install_url, 'install-theme_' . $parent_theme_name );
@@ -399 +403 @@
 </div>
 
-<?php
+    <?php
 }
 ?>
@@ -534 +538 @@
 
 wp_localize_script(
-    'updates', '_wpUpdatesItemCounts', array(
+    'updates',
+    '_wpUpdatesItemCounts',
+    array(
         'totals' => wp_get_update_data(),
     )