Changeset 43571 for trunk/src/wp-content/themes/twentytwelve/image.php

Timestamp:

08/17/2018 01:50:26 AM (8 years ago)

Author:

pento

Message:

Coding Standards: Upgrade WPCS to 1.0.0

WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:

• Multiline function calls must now put each parameter on a new line.
• Auto-formatting files is now part of the grunt precommit script.
• Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.

File:

• trunk/src/wp-content/themes/twentytwelve/image.php (modified) (4 diffs)

trunk/src/wp-content/themes/twentytwelve/image.php

@@ -18 +18 @@
                 while ( have_posts() ) :
                         the_post();
-?>
+                        ?>
 
                                 <article id="post-<?php the_ID(); ?>" <?php post_class( 'image-attachment' ); ?>>
@@ -52 +52 @@
                                                 <div class="entry-attachment">
                                                         <div class="attachment">
-<?php
-/*
- * Grab the IDs of all the image attachments in a gallery so we can get the URL of the next adjacent image in a gallery,
- * or the first image (if we're looking at the last image in a gallery), or, in a gallery of one, just the link to that image file
- */
-$attachments = array_values(
-        get_children(
-                array(
-                        'post_parent'    => $post->post_parent,
-                        'post_status'    => 'inherit',
-                        'post_type'      => 'attachment',
-                        'post_mime_type' => 'image',
-                        'order'          => 'ASC',
-                        'orderby'        => 'menu_order ID',
-                )
-        )
-);
-foreach ( $attachments as $k => $attachment ) :
-        if ( $attachment->ID == $post->ID ) {
-                break;
-        }
+                        <?php
+                        /*
+                        * Grab the IDs of all the image attachments in a gallery so we can get the URL of the next adjacent image in a gallery,
+                        * or the first image (if we're looking at the last image in a gallery), or, in a gallery of one, just the link to that image file
+                        */
+                        $attachments = array_values(
+                                get_children(
+                                        array(
+                                                'post_parent'    => $post->post_parent,
+                                                'post_status'    => 'inherit',
+                                                'post_type'      => 'attachment',
+                                                'post_mime_type' => 'image',
+                                                'order'          => 'ASC',
+                                                'orderby'        => 'menu_order ID',
+                                        )
+                                )
+                        );
+                        foreach ( $attachments as $k => $attachment ) :
+                                if ( $attachment->ID == $post->ID ) {
+                                        break;
+                                }
 endforeach;
 
-// If there is more than 1 attachment in a gallery
-if ( count( $attachments ) > 1 ) :
-        $k++;
-        if ( isset( $attachments[ $k ] ) ) :
-                // get the URL of the next image attachment
-                $next_attachment_url = get_attachment_link( $attachments[ $k ]->ID );
-        else :
-                // or get the URL of the first image attachment
-                $next_attachment_url = get_attachment_link( $attachments[0]->ID );
-        endif;
+                        // If there is more than 1 attachment in a gallery
+                        if ( count( $attachments ) > 1 ) :
+                                $k++;
+                                if ( isset( $attachments[ $k ] ) ) :
+                                        // get the URL of the next image attachment
+                                        $next_attachment_url = get_attachment_link( $attachments[ $k ]->ID );
+                                else :
+                                        // or get the URL of the first image attachment
+                                        $next_attachment_url = get_attachment_link( $attachments[0]->ID );
+                                endif;
 else :
         // or, if there's only 1 image, get the URL of the image
@@ -104 +104 @@
                                                                                                         $attachment_size = apply_filters( 'twentytwelve_attachment_size', array( 960, 960 ) );
                                                                                                         echo wp_get_attachment_image( $post->ID, $attachment_size );
-                                                                ?>
+                                                                                                        ?>
                                                                 </a>
 
@@ -125 +125 @@
                                                                 )
                                                         );
-?>
+                                                        ?>
                                                 </div><!-- .entry-description -->