Changeset 43571 for trunk/src/wp-includes/comment-template.php

Timestamp:

08/17/2018 01:50:26 AM (6 years ago)

Author:

pento

Message:

Coding Standards: Upgrade WPCS to 1.0.0

WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:

• Multiline function calls must now put each parameter on a new line.
• Auto-formatting files is now part of the grunt precommit script.
• Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.

File:

• trunk/src/wp-includes/comment-template.php (modified) (7 diffs)

trunk/src/wp-includes/comment-template.php

@@ -1153 +1153 @@
     if ( true !== $deprecated_echo ) {
         _deprecated_argument(
-            __FUNCTION__, '2.5.0',
+            __FUNCTION__,
+            '2.5.0',
             /* translators: %s: get_trackback_url() */
             sprintf(
@@ -1677 +1678 @@
     } else {
         $data_attributes = array(
-            'commentid'        => $comment->comment_ID,
-            'postid'           => $post->ID,
-            'belowelement'     => $args['add_below'] . '-' . $comment->comment_ID,
-            'respondelement'   => $args['respond_id'],
+            'commentid'      => $comment->comment_ID,
+            'postid'         => $post->ID,
+            'belowelement'   => $args['add_below'] . '-' . $comment->comment_ID,
+            'respondelement' => $args['respond_id'],
         );
 
@@ -1686 +1687 @@
 
         foreach ( $data_attributes as $name => $value ) {
-            $data_attribute_string .= " data-${name}=\"" . esc_attr( $value ) . "\"";
+            $data_attribute_string .= " data-${name}=\"" . esc_attr( $value ) . '"';
         }
 
@@ -1693 +1694 @@
         $link = sprintf(
             "<a rel='nofollow' class='comment-reply-link' href='%s' %s aria-label='%s'>%s</a>",
-            esc_url( add_query_arg( 'replytocom', $comment->comment_ID ) ) . "#" . $args['respond_id'],
+            esc_url( add_query_arg( 'replytocom', $comment->comment_ID ) ) . '#' . $args['respond_id'],
             $data_attribute_string,
             esc_attr( sprintf( $args['reply_to_text'], $comment->comment_author ) ),
@@ -1780 +1781 @@
         $onclick = sprintf(
             'return addComment.moveForm( "%1$s-%2$s", "0", "%3$s", "%2$s" )',
-            $args['add_below'], $post->ID, $args['respond_id']
+            $args['add_below'],
+            $post->ID,
+            $args['respond_id']
         );
 
@@ -2264 +2267 @@
     $html5    = 'html5' === $args['format'];
     $fields   = array(
-        'author'  => '<p class="comment-form-author">' . '<label for="author">' . __( 'Name' ) . ( $req ? ' <span class="required">*</span>' : '' ) . '</label> ' .
+        'author' => '<p class="comment-form-author">' . '<label for="author">' . __( 'Name' ) . ( $req ? ' <span class="required">*</span>' : '' ) . '</label> ' .
                      '<input id="author" name="author" type="text" value="' . esc_attr( $commenter['comment_author'] ) . '" size="30" maxlength="245"' . $html_req . ' /></p>',
-        'email'   => '<p class="comment-form-email"><label for="email">' . __( 'Email' ) . ( $req ? ' <span class="required">*</span>' : '' ) . '</label> ' .
+        'email'  => '<p class="comment-form-email"><label for="email">' . __( 'Email' ) . ( $req ? ' <span class="required">*</span>' : '' ) . '</label> ' .
                      '<input id="email" name="email" ' . ( $html5 ? 'type="email"' : 'type="text"' ) . ' value="' . esc_attr( $commenter['comment_author_email'] ) . '" size="30" maxlength="100" aria-describedby="email-notes"' . $html_req . ' /></p>',
-        'url'     => '<p class="comment-form-url"><label for="url">' . __( 'Website' ) . '</label> ' .
+        'url'    => '<p class="comment-form-url"><label for="url">' . __( 'Website' ) . '</label> ' .
                      '<input id="url" name="url" ' . ( $html5 ? 'type="url"' : 'type="text"' ) . ' value="' . esc_attr( $commenter['comment_author_url'] ) . '" size="30" maxlength="200" /></p>',
     );
@@ -2377 +2380 @@
             do_action( 'comment_form_must_log_in_after' );
         else :
-        ?>
+            ?>
             <form action="<?php echo esc_url( $args['action'] ); ?>" method="post" id="<?php echo esc_attr( $args['id_form'] ); ?>" class="<?php echo esc_attr( $args['class_form'] ); ?>"<?php echo $html5 ? ' novalidate' : ''; ?>>
                 <?php