WordPress.org

Make WordPress Core


Ignore:
Timestamp:
08/17/2018 01:50:26 AM (3 years ago)
Author:
pento
Message:

Coding Standards: Upgrade WPCS to 1.0.0

WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:

  • Multiline function calls must now put each parameter on a new line.
  • Auto-formatting files is now part of the grunt precommit script.
  • Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/admin/includesFile.php

    r42773 r43571  
    4141        $error = download_url( 'test_download_url_non_200' );
    4242        $this->assertWPError( $error );
    43         $this->assertEquals( array(
    44             'code' => 418,
    45             'body' => 'This is an unexpected error message from your favorite server.',
    46         ), $error->get_error_data() );
     43        $this->assertEquals(
     44            array(
     45                'code' => 418,
     46                'body' => 'This is an unexpected error message from your favorite server.',
     47            ),
     48            $error->get_error_data()
     49        );
    4750
    4851        add_filter( 'download_url_error_max_body_size', array( $this, '__return_5' ) );
     
    5053        $error = download_url( 'test_download_url_non_200' );
    5154        $this->assertWPError( $error );
    52         $this->assertEquals( array(
    53             'code' => 418,
    54             'body' => 'This ',
    55         ), $error->get_error_data() );
     55        $this->assertEquals(
     56            array(
     57                'code' => 418,
     58                'body' => 'This ',
     59            ),
     60            $error->get_error_data()
     61        );
    5662
    5763        remove_filter( 'download_url_error_max_body_size', array( $this, '__return_5' ) );
Note: See TracChangeset for help on using the changeset viewer.