WordPress.org

Make WordPress Core


Ignore:
Timestamp:
08/17/2018 01:50:26 AM (3 years ago)
Author:
pento
Message:

Coding Standards: Upgrade WPCS to 1.0.0

WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:

  • Multiline function calls must now put each parameter on a new line.
  • Auto-formatting files is now part of the grunt precommit script.
  • Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/oembed/template.php

    r42343 r43571  
    4444        $file          = DIR_TESTDATA . '/images/canola.jpg';
    4545        $attachment_id = self::factory()->attachment->create_object(
    46             $file, $post_id, array(
     46            $file,
     47            $post_id,
     48            array(
    4749                'post_mime_type' => 'image/jpeg',
    4850            )
     
    8486        $file          = DIR_TESTDATA . '/images/canola.jpg';
    8587        $attachment_id = self::factory()->attachment->create_object(
    86             $file, $post->ID, array(
     88            $file,
     89            $post->ID,
     90            array(
    8791                'post_mime_type' => 'image/jpeg',
    8892                'post_title'     => 'Hello World',
     
    245249        $file          = DIR_TESTDATA . '/images/canola.jpg';
    246250        $attachment_id = self::factory()->attachment->create_object(
    247             $file, $post_id, array(
     251            $file,
     252            $post_id,
     253            array(
    248254                'post_mime_type' => 'image/jpeg',
    249255            )
Note: See TracChangeset for help on using the changeset viewer.