WordPress.org

Make WordPress Core


Ignore:
Timestamp:
08/17/2018 01:50:26 AM (3 years ago)
Author:
pento
Message:

Coding Standards: Upgrade WPCS to 1.0.0

WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:

  • Multiline function calls must now put each parameter on a new line.
  • Auto-formatting files is now part of the grunt precommit script.
  • Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/rewrite.php

    r42343 r43571  
    5454
    5555        $wp_rewrite->add_rule(
    56             $pattern, array(
     56            $pattern,
     57            array(
    5758                'test_var1' => '$matches[1]',
    5859                'test_var2' => '1',
     
    283284                'page'     => '',
    284285                'pagename' => 'page',
    285             ), $GLOBALS['wp']->query_vars
     286            ),
     287            $GLOBALS['wp']->query_vars
    286288        );
    287289    }
     
    303305                'page'     => '',
    304306                'pagename' => 'page',
    305             ), $GLOBALS['wp']->query_vars
     307            ),
     308            $GLOBALS['wp']->query_vars
    306309        );
    307310
     
    311314                'page'     => '',
    312315                'pagename' => 'page',
    313             ), $GLOBALS['wp']->query_vars
     316            ),
     317            $GLOBALS['wp']->query_vars
    314318        );
    315319        $this->assertEquals(
     
    317321                'page'     => '',
    318322                'pagename' => 'match/page',
    319             ), $GLOBALS['wp']->query_vars
     323            ),
     324            $GLOBALS['wp']->query_vars
    320325        );
    321326    }
Note: See TracChangeset for help on using the changeset viewer.