Changeset 43592

Timestamp:

08/30/2018 09:00:42 AM (18 months ago)

Author:

SergeyBiryukov

Message:

Post Formats: Don't assign a variable inside if statement in get_post_format().

Props Mirucon.
Fixes #44840.

File:

• trunk/src/wp-includes/post-formats.php (modified) (2 diffs)

trunk/src/wp-includes/post-formats.php

@@ -16 +16 @@
  */
 function get_post_format( $post = null ) {
-    if ( ! $post = get_post( $post ) ) {
+    $post = get_post( $post );
+
+    if ( ! $post ) {
         return false;
     }
@@ -68 +70 @@
     $post = get_post( $post );
 
-    if ( empty( $post ) ) {
+    if ( ! $post ) {
         return new WP_Error( 'invalid_post', __( 'Invalid post.' ) );
     }