Changeset 43598 for trunk/src/wp-admin/includes/ajax-actions.php

Timestamp:

08/30/2018 01:35:27 PM (6 years ago)

Author:

jrf

Message:

I18n: Improve translators comments [3].

• Add missing translators comments.
• Fix placement of some translators comments. Translators comments should be on the line directly above the line containing the translation function call for optimal compatibility with various .pot file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translators comments.

Includes minor code layout fixes.

Patch 44360-wp-admin-includes-dir.patch of the series.

Props flipkeijzer, alvarogois, michielatyoast
See #44360

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (7 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -391 +391 @@
                     'in_moderation'        => $counts->moderated,
                     'i18n_comments_text'   => sprintf(
+                        /* translators: %s: number of comments approved */
                         _n( '%s Comment', '%s Comments', $counts->approved ),
                         number_format_i18n( $counts->approved )
                     ),
                     'i18n_moderation_text' => sprintf(
+                        /* translators: %s: number of comments in moderation */
                         _nx( '%s in moderation', '%s in moderation', $counts->moderated, 'comments' ),
                         number_format_i18n( $counts->moderated )
@@ -453 +455 @@
                 'status'           => $comment ? $comment->comment_approved : '',
                 'postId'           => $comment ? $comment->comment_post_ID : '',
+                /* translators: %s: number of comments */
                 'total_items_i18n' => sprintf( _n( '%s item', '%s items', $total ), number_format_i18n( $total ) ),
                 'total_pages'      => ceil( $total / $per_page ),
@@ -836 +839 @@
             array(
                 'what' => 'comment',
+                /* translators: %d: comment ID */
                 'id'   => new WP_Error( 'invalid_comment', sprintf( __( 'Comment %d does not exist' ), $id ) ),
             )
@@ -1215 +1219 @@
         'in_moderation'        => $counts->moderated,
         'i18n_comments_text'   => sprintf(
+            /* translators: %s: number of comments approved */
             _n( '%s Comment', '%s Comments', $counts->approved ),
             number_format_i18n( $counts->approved )
         ),
         'i18n_moderation_text' => sprintf(
+            /* translators: %s: number of comments moderated */
             _nx( '%s in moderation', '%s in moderation', $counts->moderated, 'comments' ),
             number_format_i18n( $counts->moderated )
@@ -1814 +1820 @@
         $last_user      = get_userdata( $last );
         $last_user_name = $last_user ? $last_user->display_name : __( 'Someone' );
-        printf( $_POST['post_type'] == 'page' ? __( 'Saving is disabled: %s is currently editing this page.' ) : __( 'Saving is disabled: %s is currently editing this post.' ), esc_html( $last_user_name ) );
+
+        /* translators: %s: user who is currently editing the post */
+        $msg_template = __( 'Saving is disabled: %s is currently editing this post.' );
+        if ( $_POST['post_type'] == 'page' ) {
+            /* translators: %s: user who is currently editing the page */
+            $msg_template = __( 'Saving is disabled: %s is currently editing this page.' );
+        }
+
+        printf( $msg_template, esc_html( $last_user_name ) );
         wp_die();
     }
@@ -2509 +2523 @@
 
     if ( $last_id = get_post_meta( $post_id, '_edit_last', true ) ) {
-        $last_user   = get_userdata( $last_id );
+        $last_user = get_userdata( $last_id );
+        /* translators: 1: display_name of last user, 2: date of last edit, 3: time of last edit. */
         $last_edited = sprintf( __( 'Last edited by %1$s on %2$s at %3$s' ), esc_html( $last_user->display_name ), $last_date, $last_time );
     } else {
+        /* translators: 1: date of last edit, 2: time of last edit. */
         $last_edited = sprintf( __( 'Last edited on %1$s at %2$s' ), $last_date, $last_time );
     }
@@ -3337 +3353 @@
             array(
                 'type'    => 'not-embeddable',
+                /* translators: %s: URL which cannot be embedded, between code tags */
                 'message' => sprintf( __( '%s failed to embed.' ), '<code>' . esc_html( $url ) . '</code>' ),
             )