Changeset 43605

Timestamp:

09/02/2018 10:08:05 PM (8 years ago)

Author:

SergeyBiryukov

Message:

Taxonomy: Make sure wp_list_categories() correctly outputs term name of 0.

Props joyously, SergeyBiryukov.
Fixes #44872.

Location:

trunk

Files:

• src/wp-includes/class-walker-category.php (modified) (1 diff)
• tests/phpunit/tests/category/wpListCategories.php (modified) (2 diffs)

trunk/src/wp-includes/class-walker-category.php

@@ -105 +105 @@
 
                 // Don't generate an element if the category name is empty.
-                if ( ! $cat_name ) {
+                if ( '' === $cat_name ) {
                         return;
                 }

trunk/tests/phpunit/tests/category/wpListCategories.php

@@ -104 +104 @@
         }
 
+        public function list_cats_callback( $cat ) {
+                if ( 'Test Cat 1' === $cat ) {
+                        return '';
+                }
+
+                return $cat;
+        }
+
+        /**
+         * @ticket 44872
+         */
+        public function test_should_create_element_when_cat_name_is_zero() {
+                $c = self::factory()->category->create(
+                        array(
+                                'name' => '0',
+                        )
+                );
+
+                $found = wp_list_categories(
+                        array(
+                                'hide_empty' => false,
+                                'echo'       => false,
+                        )
+                );
+
+                $this->assertContains( "cat-item-$c", $found );
+                $this->assertContains( '0', $found );
+        }
+
         public function test_show_option_all_link_should_go_to_home_page_when_show_on_front_is_false() {
                 $cats = self::factory()->category->create_many( 2 );
@@ -248 +277 @@
         }
 
-        public function list_cats_callback( $cat ) {
-                if ( 'Test Cat 1' === $cat ) {
-                        return '';
-                }
-
-                return $cat;
-        }
-
         /**
          * @ticket 33460