Changeset 43641

Timestamp:

09/14/2018 07:54:53 AM (6 years ago)

Author:

flixos90

Message:

Upgrade/Install: Properly exclude the admin/includesSchema.php tests file for the WordPress.DB.PreparedSQL.NotPrepared sniff.

The way this was implemented in [43630] caused the file to be excluded for all sniffs, since PHPCS does not support file-wide ignores of a specific sniff at this point.

Props jrf.
See #44896.

Location:

trunk

Files:

• phpcs.xml.dist (modified) (1 diff)
• tests/phpunit/tests/admin/includesSchema.php (modified) (1 diff)

trunk/phpcs.xml.dist

@@ -82 +82 @@
         <exclude-pattern>/tests/phpunit/tests/db\.php</exclude-pattern>
     </rule>
+    <rule ref="WordPress.DB.PreparedSQL.NotPrepared">
+        <exclude-pattern>/tests/phpunit/tests/admin/includesSchema\.php</exclude-pattern>
+    </rule>
 
     <!-- Whitelist the I18n functions file from issues identified by the I18n sniff

trunk/tests/phpunit/tests/admin/includesSchema.php

@@ -1 +1 @@
 <?php
-// phpcs:ignoreFile WordPress.DB.PreparedSQL.NotPrepared
 
 /**