Changeset 43667

Timestamp:

10/02/2018 07:29:18 PM (8 years ago)

Author:

pento

Message:

Plugins: Pluralise the "unexpected output during activation" message.

When a plugin is activated, it can trigger a warning message if it outputs data at that time. This error message was being run through __(), instead of _n(), so it wasn't possible to correctly pluralise the message.

Props jamosova.
Fixes #42355.

File:

• trunk/src/wp-admin/plugins.php (modified) (1 diff)

trunk/src/wp-admin/plugins.php

@@ -480 +480 @@
                 $errmsg = __( 'You cannot delete a plugin while it is active on the main site.' );
         } elseif ( isset( $_GET['charsout'] ) ) {
-                $errmsg = sprintf( __( 'The plugin generated %d characters of <strong>unexpected output</strong> during activation. If you notice &#8220;headers already sent&#8221; messages, problems with syndication feeds or other issues, try deactivating or removing this plugin.' ), $_GET['charsout'] );
+                $errmsg  = sprintf(
+                        _n(
+                                'The plugin generated %d character of <strong>unexpected output</strong> during activation.',
+                                'The plugin generated %d characters of <strong>unexpected output</strong> during activation.',
+                                $_GET['charsout']
+                        ),
+                        $_GET['charsout']
+                );
+                $errmsg .= ' ' . __( 'If you notice &#8220;headers already sent&#8221; messages, problems with syndication feeds or other issues, try deactivating or removing this plugin.' );
         } else {
                 $errmsg = __( 'Plugin could not be activated because it triggered a <strong>fatal error</strong>.' );