Changeset 43680

Timestamp:

10/08/2018 01:49:51 PM (8 years ago)

Author:

danielbachhuber

Message:

REST API: Define taxonomy visibility settings in schema

For Gutenberg and other admin-type interfaces, it's
useful to be able to see the visibility settings for
taxonomies.

The original changeset was partially included in [43445].

Merges [42729], [42730], [42973] to the 5.0 branch.
Props joehoyle, TimothyBlynJacobs, pento.
Fixes #42707

Location:

branches/5.0

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-taxonomies-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-taxonomies-controller.php (modified) (3 diffs)

branches/5.0/src/wp-includes/rest-api/endpoints/class-wp-rest-taxonomies-controller.php

@@ -323 +323 @@
                                         'readonly'     => true,
                                 ),
+                                'visibility'       => array(
+                                        'description'  => __( 'The visibility settings for the taxonomy.' ),
+                                        'type'         => 'object',
+                                        'context'      => array( 'edit' ),
+                                        'readonly'     => true,
+                                ),
                                 'rest_base'            => array(
                                         'description'  => __( 'REST base route for the taxonomy.' ),

branches/5.0/tests/phpunit/tests/rest-api/rest-taxonomies-controller.php

@@ -198 +198 @@
                 $data = $response->get_data();
                 $properties = $data['schema']['properties'];
-                $this->assertEquals( 9, count( $properties ) );
+                $this->assertEquals( 10, count( $properties ) );
                 $this->assertArrayHasKey( 'capabilities', $properties );
                 $this->assertArrayHasKey( 'description', $properties );
@@ -207 +207 @@
                 $this->assertArrayHasKey( 'show_cloud', $properties );
                 $this->assertArrayHasKey( 'types', $properties );
+                $this->assertArrayHasKey( 'visibility', $properties );
                 $this->assertArrayHasKey( 'rest_base', $properties );
         }
@@ -240 +241 @@
                         $this->assertEquals( $tax_obj->labels, $data['labels'] );
                         $this->assertEquals( $tax_obj->show_tagcloud, $data['show_cloud'] );
+
+                        $this->assertEquals( $tax_obj->public, $data['visibility']['public'] );
+                        $this->assertEquals( $tax_obj->publicly_queryable, $data['visibility']['publicly_queryable'] );
+                        $this->assertEquals( $tax_obj->show_admin_column, $data['visibility']['show_admin_column'] );
+                        $this->assertEquals( $tax_obj->show_in_nav_menus, $data['visibility']['show_in_nav_menus'] );
+                        $this->assertEquals( $tax_obj->show_in_quick_edit, $data['visibility']['show_in_quick_edit'] );
+                        $this->assertEquals( $tax_obj->show_ui, $data['visibility']['show_ui'] );
                 } else {
                         $this->assertFalse( isset( $data['capabilities'] ) );
                         $this->assertFalse( isset( $data['labels'] ) );
                         $this->assertFalse( isset( $data['show_cloud'] ) );
+                        $this->assertFalse( isset( $data['visibility'] ) );
                 }
         }