Changeset 43714

Timestamp:

10/11/2018 06:34:34 AM (6 years ago)

Author:

SergeyBiryukov

Message:

REST API: Pass correct ID to meta->update_value to permit setting term meta during term creation.

Props joehoyle.
Merges [43636] to the 5.0 branch.
Fixes #44834.

Location:

branches/5.0

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-tags-controller.php (modified) (1 diff)

branches/5.0/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php

@@ -442 +442 @@
         $schema = $this->get_item_schema();
         if ( ! empty( $schema['properties']['meta'] ) && isset( $request['meta'] ) ) {
-            $meta_update = $this->meta->update_value( $request['meta'], (int) $request['id'] );
+            $meta_update = $this->meta->update_value( $request['meta'], $term->term_id );
 
             if ( is_wp_error( $meta_update ) ) {

branches/5.0/tests/phpunit/tests/rest-api/rest-tags-controller.php

@@ -676 +676 @@
     }
 
+    public function test_create_item_with_meta() {
+        wp_set_current_user( self::$administrator );
+        $request = new WP_REST_Request( 'POST', '/wp/v2/tags' );
+        $request->set_param( 'name', 'My Awesome Term' );
+        $request->set_param( 'meta', array( 'test_tag_single' => 'hello' ) );
+        $response = rest_get_server()->dispatch( $request );
+        $this->assertEquals( 201, $response->get_status() );
+        $headers = $response->get_headers();
+        $data    = $response->get_data();
+        $this->assertContains( '/wp/v2/tags/' . $data['id'], $headers['Location'] );
+        $this->assertEquals( 'My Awesome Term', $data['name'] );
+        $this->assertEquals( 'hello', get_term_meta( $data['id'], 'test_tag_single', true ) );
+    }
+
+    public function test_create_item_with_meta_wrong_id() {
+        wp_set_current_user( self::$administrator );
+        $existing_tag_id = $this->factory->tag->create( array( 'name' => 'My Not So Awesome Term' ) );
+        $request         = new WP_REST_Request( 'POST', '/wp/v2/tags' );
+        $request->set_param( 'name', 'My Awesome Term' );
+        $request->set_param( 'meta', array( 'test_tag_single' => 'hello' ) );
+        $request->set_param( 'id', $existing_tag_id );
+        $response = rest_get_server()->dispatch( $request );
+        $this->assertEquals( 201, $response->get_status() );
+        $headers = $response->get_headers();
+        $data    = $response->get_data();
+        $this->assertContains( '/wp/v2/tags/' . $data['id'], $headers['Location'] );
+        $this->assertEquals( 'My Awesome Term', $data['name'] );
+        $this->assertEquals( '', get_term_meta( $existing_tag_id, 'test_tag_single', true ) );
+        $this->assertEquals( 'hello', get_term_meta( $data['id'], 'test_tag_single', true ) );
+    }
+
     public function test_update_item() {
         wp_set_current_user( self::$administrator );