Changeset 4372

Timestamp:

10/11/2006 09:18:54 AM (18 years ago)

Author:

markjaquith

Message:

Post meta caching fix by mdawaffe. fixes #3229

Location:

trunk/wp-includes

Files:

• functions.php (modified) (1 diff)
• post-template.php (modified) (1 diff)
• post.php (modified) (9 diffs)

trunk/wp-includes/functions.php

@@ -543 +543 @@
         $post_meta_cache = array();
         foreach ($meta_list as $metarow) {
-            $mpid = $metarow['post_id'];
+            $mpid = (int) $metarow['post_id'];
             $mkey = $metarow['meta_key'];
             $mval = $metarow['meta_value'];

trunk/wp-includes/post-template.php

@@ -212 +212 @@
 // this will probably change at some point...
 function the_meta() {
-    global $id, $post_meta_cache;
+    global $id;
 
     if ( $keys = get_post_custom_keys() ) {

trunk/wp-includes/post.php

@@ -222 +222 @@
     global $wpdb, $post_meta_cache;
 
+    $post_id = (int) $post_id;
+
     if ( $unique ) {
-        if ( $wpdb->get_var("SELECT meta_key FROM $wpdb->postmeta WHERE meta_key
-= '$key' AND post_id = '$post_id'") ) {
+        if ( $wpdb->get_var("SELECT meta_key FROM $wpdb->postmeta WHERE meta_key = '$key' AND post_id = '$post_id'") ) {
             return false;
         }
@@ -235 +236 @@
     $wpdb->query("INSERT INTO $wpdb->postmeta (post_id,meta_key,meta_value) VALUES ('$post_id','$key','$value')");
 
-    $post_meta_cache['$post_id'][$key][] = $original;
+    $post_meta_cache[$post_id][$key][] = $original;
 
     return true;
@@ -243 +244 @@
     global $wpdb, $post_meta_cache;
 
+    $post_id = (int) $post_id;
+
     if ( empty($value) ) {
-        $meta_id = $wpdb->get_var("SELECT meta_id FROM $wpdb->postmeta WHERE
-post_id = '$post_id' AND meta_key = '$key'");
-    } else {
-        $meta_id = $wpdb->get_var("SELECT meta_id FROM $wpdb->postmeta WHERE
-post_id = '$post_id' AND meta_key = '$key' AND meta_value = '$value'");
+        $meta_id = $wpdb->get_var("SELECT meta_id FROM $wpdb->postmeta WHERE post_id = '$post_id' AND meta_key = '$key'");
+    } else {
+        $meta_id = $wpdb->get_var("SELECT meta_id FROM $wpdb->postmeta WHERE post_id = '$post_id' AND meta_key = '$key' AND meta_value = '$value'");
     }
 
@@ -255 +256 @@
 
     if ( empty($value) ) {
-        $wpdb->query("DELETE FROM $wpdb->postmeta WHERE post_id = '$post_id'
-AND meta_key = '$key'");
-        unset($post_meta_cache['$post_id'][$key]);
-    } else {
-        $wpdb->query("DELETE FROM $wpdb->postmeta WHERE post_id = '$post_id'
-AND meta_key = '$key' AND meta_value = '$value'");
-        $cache_key = $post_meta_cache['$post_id'][$key];
+        $wpdb->query("DELETE FROM $wpdb->postmeta WHERE post_id = '$post_id' AND meta_key = '$key'");
+        unset($post_meta_cache[$post_id][$key]);
+    } else {
+        $wpdb->query("DELETE FROM $wpdb->postmeta WHERE post_id = '$post_id' AND meta_key = '$key' AND meta_value = '$value'");
+        $cache_key = $post_meta_cache[$post_id][$key];
         if ($cache_key) foreach ( $cache_key as $index => $data )
             if ( $data == $value )
-                unset($post_meta_cache['$post_id'][$key][$index]);
-    }
-
-    unset($post_meta_cache['$post_id'][$key]);
+                unset($post_meta_cache[$post_id][$key][$index]);
+    }
+
+    unset($post_meta_cache[$post_id][$key]);
 
     return true;
@@ -274 +273 @@
 function get_post_meta($post_id, $key, $single = false) {
     global $wpdb, $post_meta_cache;
+
+    $post_id = (int) $post_id;
 
     if ( isset($post_meta_cache[$post_id][$key]) ) {
@@ -308 +309 @@
     global $wpdb, $post_meta_cache;
 
+    $post_id = (int) $post_id;
+
     $original_value = $value;
     if ( is_array($value) || is_object($value) )
@@ -316 +319 @@
         $prev_value = $wpdb->escape(serialize($prev_value));
 
-    if (! $wpdb->get_var("SELECT meta_key FROM $wpdb->postmeta WHERE meta_key
-= '$key' AND post_id = '$post_id'") ) {
+    if (! $wpdb->get_var("SELECT meta_key FROM $wpdb->postmeta WHERE meta_key = '$key' AND post_id = '$post_id'") ) {
         return false;
     }
 
     if ( empty($prev_value) ) {
-        $wpdb->query("UPDATE $wpdb->postmeta SET meta_value = '$value' WHERE
-meta_key = '$key' AND post_id = '$post_id'");
-        $cache_key = $post_meta_cache['$post_id'][$key];
+        $wpdb->query("UPDATE $wpdb->postmeta SET meta_value = '$value' WHERE meta_key = '$key' AND post_id = '$post_id'");
+        $cache_key = $post_meta_cache[$post_id][$key];
         if ( !empty($cache_key) )
             foreach ($cache_key as $index => $data)
-                $post_meta_cache['$post_id'][$key][$index] = $original_value;
-    } else {
-        $wpdb->query("UPDATE $wpdb->postmeta SET meta_value = '$value' WHERE
-meta_key = '$key' AND post_id = '$post_id' AND meta_value = '$prev_value'");
-        $cache_key = $post_meta_cache['$post_id'][$key];
+                $post_meta_cache[$post_id][$key][$index] = $original_value;
+    } else {
+        $wpdb->query("UPDATE $wpdb->postmeta SET meta_value = '$value' WHERE meta_key = '$key' AND post_id = '$post_id' AND meta_value = '$prev_value'");
+        $cache_key = $post_meta_cache[$post_id][$key];
         if ( !empty($cache_key) )
             foreach ($cache_key as $index => $data)
                 if ( $data == $original_prev )
-                    $post_meta_cache['$post_id'][$key][$index] = $original_value;
+                    $post_meta_cache[$post_id][$key][$index] = $original_value;
     }
 
@@ -347 +347 @@
     if ( ! $post_id )
         $post_id = $id;
+
+    $post_id = (int) $post_id;
 
     if ( isset($post_meta_cache[$post_id]) )
@@ -355 +357 @@
         $post_meta_cache = array();
         foreach ( $meta_list as $metarow ) {
-            $mpid = $metarow['post_id'];
+            $mpid = (int) $metarow['post_id'];
             $mkey = $metarow['meta_key'];
             $mval = $metarow['meta_value'];