Changeset 43729 for branches/5.0/src/wp-includes/comment.php

Timestamp:

10/15/2018 11:45:16 AM (8 years ago)

Author:

flixos90

Message:

REST API: Move object type-specific metadata integrations from the wrapper functions to the low-level Meta API functions.

Object type-specific actions that should happen before or after modification of metadata have so far been part of the respective wrapper functions. By using action and filter hooks, this changeset ensures they are always executed, even when calling the lower-level Meta API functions directly, which the REST API does as a prime example.

Props flixos90, spacedmonkey.
Fixes #44467.

File:

• branches/5.0/src/wp-includes/comment.php (modified) (6 diffs)

branches/5.0/src/wp-includes/comment.php

@@ -423 +423 @@
  * @return int|bool Meta ID on success, false on failure.
  */
-function add_comment_meta($comment_id, $meta_key, $meta_value, $unique = false) {
-        $added = add_metadata( 'comment', $comment_id, $meta_key, $meta_value, $unique );
-        if ( $added ) {
-                wp_cache_set( 'last_changed', microtime(), 'comment' );
-        }
-        return $added;
+function add_comment_meta( $comment_id, $meta_key, $meta_value, $unique = false ) {
+        return add_metadata( 'comment', $comment_id, $meta_key, $meta_value, $unique );
 }
 
@@ -446 +442 @@
  * @return bool True on success, false on failure.
  */
-function delete_comment_meta($comment_id, $meta_key, $meta_value = '') {
-        $deleted = delete_metadata( 'comment', $comment_id, $meta_key, $meta_value );
-        if ( $deleted ) {
-                wp_cache_set( 'last_changed', microtime(), 'comment' );
-        }
-        return $deleted;
+function delete_comment_meta( $comment_id, $meta_key, $meta_value = '' ) {
+        return delete_metadata( 'comment', $comment_id, $meta_key, $meta_value );
 }
 
@@ -466 +458 @@
  *  is true.
  */
-function get_comment_meta($comment_id, $key = '', $single = false) {
-        return get_metadata('comment', $comment_id, $key, $single);
+function get_comment_meta( $comment_id, $key = '', $single = false ) {
+        return get_metadata( 'comment', $comment_id, $key, $single );
 }
 
@@ -487 +479 @@
  * @return int|bool Meta ID if the key didn't exist, true on successful update, false on failure.
  */
-function update_comment_meta($comment_id, $meta_key, $meta_value, $prev_value = '') {
-        $updated = update_metadata( 'comment', $comment_id, $meta_key, $meta_value, $prev_value );
-        if ( $updated ) {
-                wp_cache_set( 'last_changed', microtime(), 'comment' );
-        }
-        return $updated;
+function update_comment_meta( $comment_id, $meta_key, $meta_value, $prev_value = '' ) {
+        return update_metadata( 'comment', $comment_id, $meta_key, $meta_value, $prev_value );
 }
 
@@ -3062 +3050 @@
                  */
                 do_action( 'comment_on_draft', $comment_post_ID );
-                
+
                 if ( current_user_can( 'read_post', $comment_post_ID ) ) {
                         return new WP_Error( 'comment_on_draft', __( 'Sorry, comments are not allowed for this item.' ), 403 );
@@ -3388 +3376 @@
         );
 }
+
+/**
+ * Sets the last changed time for the 'comment' cache group.
+ *
+ * @since 5.0.0
+ */
+function wp_cache_set_comments_last_changed() {
+        wp_cache_set( 'last_changed', microtime(), 'comment' );
+}